From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: Ahsan Hadi <ahsan.hadi@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: more ALTER .. DEPENDS ON EXTENSION fixes
Date: Wed, 11 Mar 2020 10:30:53 -0400
Message-ID: <3926.1583937053@sss.pgh.pa.us> (raw)
In-Reply-To: <20200311141412.GA20749@alvherre.pgsql>
References: <20200311141412.GA20749@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I'm still not sure whether to apply 0003 (+ your tab-completion patch,
> thanks for it) to backbranches or just to master. It seems legitimate
> to see it as a feature addition, but OTOH the overall feature is not
> complete without it ...
0003 is the command addition to allow removing such a dependency,
right? Given the lack of field demand I see no reason to risk
adding it to the back branches.
BTW, I did not like the syntax too much. "NO DEPENDS ON EXTENSION"
doesn't seem like good English. "NOT DEPENDS ON EXTENSION" is hardly
any better. The real problem with both is that an ALTER action should
be, well, an action. A grammar stickler would say that it should be
"ALTER thing DROP DEPENDENCY ON EXTENSION ext", but perhaps we could
get away with "ALTER thing DROP DEPENDS ON EXTENSION ext" to avoid
adding a new keyword. By that logic the original command should have
been "ALTER thing ADD DEPENDS ON EXTENSION ext", but I suppose it's
too late for that.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, ibrar.ahmad@gmail.com, ahsan.hadi@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: more ALTER .. DEPENDS ON EXTENSION fixes
In-Reply-To: <3926.1583937053@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox