pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feed7.2.3 fixes (was Re: Cause of missing pg_clog files)
6+ messages / 6 participants
[nested] [flat]
* 7.2.3 fixes (was Re: Cause of missing pg_clog files)
@ 2002-09-30 15:18 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 5 replies; 6+ messages in thread
From: Tom Lane @ 2002-09-30 15:18 UTC (permalink / raw)
To: Andrew Sullivan <andrew@libertyrms.info>; +Cc: pgsql-hackers
Andrew Sullivan <andrew@libertyrms.info> writes:
> On Fri, Sep 27, 2002 at 08:30:38PM -0400, Bruce Momjian wrote:
>> OK, we need a decision on whether we are going to do a 7.2,3 or just
>> have it in beta3. If it is in 7.2.3, I would not mention it in the
>> beta3 release notes.
> If there won't be any 7.2.3,
There will be; I will backport the fixes today, and Marc promised to
roll the tarball tonight.
One thing I am undecided about: I am more than half tempted to put in
the fix that makes us able to cope with mktime's broken-before-1970
behavior in recent glibc versions (e.g., Red Hat 7.3). This seems like
a good idea considering that other Linux distros will surely be updating
glibc soon too. On the other hand, it's hard to call it a critical bug
fix --- it ain't on a par with the vacuum/clog problem, for sure. And
the patch has received only limited testing (basically just whatever
use 7.3beta1 has had). On the third hand, the patch only does something
if mktime() has already failed, so it's hard to see how it could make
life worse even if it's buggy.
Any votes on whether to fix that or leave it alone in 7.2.3? I need
some input in the next few hours ...
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: 7.2.3 fixes (was Re: Cause of missing pg_clog files)
@ 2002-09-30 15:29 Bruce Momjian <pgman@candle.pha.pa.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
4 siblings, 0 replies; 6+ messages in thread
From: Bruce Momjian @ 2002-09-30 15:29 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Andrew Sullivan <andrew@libertyrms.info>; pgsql-hackers
Tom Lane wrote:
> Andrew Sullivan <andrew@libertyrms.info> writes:
> > On Fri, Sep 27, 2002 at 08:30:38PM -0400, Bruce Momjian wrote:
> >> OK, we need a decision on whether we are going to do a 7.2,3 or just
> >> have it in beta3. If it is in 7.2.3, I would not mention it in the
> >> beta3 release notes.
>
> > If there won't be any 7.2.3,
>
> There will be; I will backport the fixes today, and Marc promised to
> roll the tarball tonight.
>
> One thing I am undecided about: I am more than half tempted to put in
> the fix that makes us able to cope with mktime's broken-before-1970
> behavior in recent glibc versions (e.g., Red Hat 7.3). This seems like
> a good idea considering that other Linux distros will surely be updating
> glibc soon too. On the other hand, it's hard to call it a critical bug
> fix --- it ain't on a par with the vacuum/clog problem, for sure. And
> the patch has received only limited testing (basically just whatever
> use 7.3beta1 has had). On the third hand, the patch only does something
> if mktime() has already failed, so it's hard to see how it could make
> life worse even if it's buggy.
>
> Any votes on whether to fix that or leave it alone in 7.2.3? I need
> some input in the next few hours ...
I think it should be put in. You work for Red Hat, and that's the least
we can do for them.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: 7.2.3 fixes (was Re: Cause of missing pg_clog files)
@ 2002-09-30 15:30 Joe Conway <mail@joeconway.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
4 siblings, 0 replies; 6+ messages in thread
From: Joe Conway @ 2002-09-30 15:30 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Andrew Sullivan <andrew@libertyrms.info>; pgsql-hackers
Tom Lane wrote:
> One thing I am undecided about: I am more than half tempted to put in
> the fix that makes us able to cope with mktime's broken-before-1970
> behavior in recent glibc versions (e.g., Red Hat 7.3). This seems like
> a good idea considering that other Linux distros will surely be updating
> glibc soon too. On the other hand, it's hard to call it a critical bug
> fix --- it ain't on a par with the vacuum/clog problem, for sure. And
> the patch has received only limited testing (basically just whatever
> use 7.3beta1 has had). On the third hand, the patch only does something
> if mktime() has already failed, so it's hard to see how it could make
> life worse even if it's buggy.
>
> Any votes on whether to fix that or leave it alone in 7.2.3? I need
> some input in the next few hours ...
>
+1 for fixing it
Joe
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: 7.2.3 fixes (was Re: Cause of missing pg_clog files)
@ 2002-09-30 15:40 Justin Clift <justin@postgresql.org>
parent: Tom Lane <tgl@sss.pgh.pa.us>
4 siblings, 0 replies; 6+ messages in thread
From: Justin Clift @ 2002-09-30 15:40 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Andrew Sullivan <andrew@libertyrms.info>; pgsql-hackers
Tom Lane wrote:
<snip>
> Any votes on whether to fix that or leave it alone in 7.2.3? I need
> some input in the next few hours ...
Including it sounds like a good idea.
'Yes' from me.
:)
Regards and best wishes,
Justin Clift
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: 7.2.3 fixes (was Re: Cause of missing pg_clog files)
@ 2002-09-30 16:56 Marc G. Fournier <scrappy@hub.org>
parent: Tom Lane <tgl@sss.pgh.pa.us>
4 siblings, 0 replies; 6+ messages in thread
From: Marc G. Fournier @ 2002-09-30 16:56 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Andrew Sullivan <andrew@libertyrms.info>; pgsql-hackers
Nothing against including it from me ...
On Mon, 30 Sep 2002, Tom Lane wrote:
> Andrew Sullivan <andrew@libertyrms.info> writes:
> > On Fri, Sep 27, 2002 at 08:30:38PM -0400, Bruce Momjian wrote:
> >> OK, we need a decision on whether we are going to do a 7.2,3 or just
> >> have it in beta3. If it is in 7.2.3, I would not mention it in the
> >> beta3 release notes.
>
> > If there won't be any 7.2.3,
>
> There will be; I will backport the fixes today, and Marc promised to
> roll the tarball tonight.
>
> One thing I am undecided about: I am more than half tempted to put in
> the fix that makes us able to cope with mktime's broken-before-1970
> behavior in recent glibc versions (e.g., Red Hat 7.3). This seems like
> a good idea considering that other Linux distros will surely be updating
> glibc soon too. On the other hand, it's hard to call it a critical bug
> fix --- it ain't on a par with the vacuum/clog problem, for sure. And
> the patch has received only limited testing (basically just whatever
> use 7.3beta1 has had). On the third hand, the patch only does something
> if mktime() has already failed, so it's hard to see how it could make
> life worse even if it's buggy.
>
> Any votes on whether to fix that or leave it alone in 7.2.3? I need
> some input in the next few hours ...
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: 7.2.3 fixes (was Re: Cause of missing pg_clog files)
@ 2002-09-30 21:07 Andrew Sullivan <andrew@libertyrms.info>
parent: Tom Lane <tgl@sss.pgh.pa.us>
4 siblings, 0 replies; 6+ messages in thread
From: Andrew Sullivan @ 2002-09-30 21:07 UTC (permalink / raw)
To: pgsql-hackers
On Mon, Sep 30, 2002 at 11:18:27AM -0400, Tom Lane wrote:
> use 7.3beta1 has had). On the third hand, the patch only does something
> if mktime() has already failed, so it's hard to see how it could make
> life worse even if it's buggy.
On those grounds alone, it seems worth putting in. As you say, it's
hard to see how it can be worse than not putting it in, even if it
turns out to be buggy. It's probably worth noting prominently in the
release notes that it has received minimal testing, though.
A
--
----
Andrew Sullivan 204-4141 Yonge Street
Liberty RMS Toronto, Ontario Canada
<andrew@libertyrms.info> M2P 2A8
+1 416 646 3304 x110
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2002-09-30 21:07 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2002-09-30 15:18 7.2.3 fixes (was Re: Cause of missing pg_clog files) Tom Lane <tgl@sss.pgh.pa.us>
2002-09-30 15:29 ` Bruce Momjian <pgman@candle.pha.pa.us>
2002-09-30 15:30 ` Joe Conway <mail@joeconway.com>
2002-09-30 15:40 ` Justin Clift <justin@postgresql.org>
2002-09-30 16:56 ` Marc G. Fournier <scrappy@hub.org>
2002-09-30 21:07 ` Andrew Sullivan <andrew@libertyrms.info>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox