public inbox for [email protected]  

help / color / mirror / Atom feed

From: Greg Burd <[email protected]>
To: Daniel Gustafsson <[email protected]>
To: David Rowley <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: Fri, 3 Oct 2025 08:13:44 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>


On Oct 3 2025, at 4:25 am, Daniel Gustafsson <[email protected]> wrote:

>> On 3 Oct 2025, at 01:36, David Rowley <[email protected]> wrote:
>> 
>> On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson <[email protected]> wrote:
>>> Another nitpick would be to remove the test for NULL in test_bms_make_singleton
>>> since that is a STRICT function, making the test for NULL
>>> superfluous code:
>> 
>> I see test_random_operations() is also strict. Is it worth getting rid
>> of the SQL NULL checks on the inputs there too? Aka, the attached.
> 
> Indeed, but reading the code I wonder if STRICT was a mistake and the intention
> was to allow NULL input?

Yes, it was an oversight after I re-worked the random function.

> That being said, the function is never called with
> NULL so that's mostly academic thinking.  +1 for removing the NULL
> checks and simplifying the code.

I agree, and thank you both for the attention to detail and interest in
this test suite.

> 
> --
> Daniel Gustafsson

best.

-greg

view thread (81+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Add tests for Bitmapset
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox