public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrei Lepikhov <[email protected]>
To: Alexander Korotkov <[email protected]>
Cc: Artur Zakirov <[email protected]>
Cc: Alexander Lakhin <[email protected]>
Cc: jian he <[email protected]>
Cc: Pavel Borisov <[email protected]>
Cc: Teodor Sigaev <[email protected]>
Cc: Pgsql Hackers <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Michael Paquier <[email protected]>
Subject: Re: type cache cleanup improvements
Date: Mon, 21 Oct 2024 09:36:04 +0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAPpHfdtj5yXgPiPJBenTLaFvBbF7U+LVpN=Eho1=o01jU_KQaA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAPpHfduPbcfQShtxGO72zr0+7EGKTob4HzQfUw7=3K3H5ZgqRw@mail.gmail.com>
	<CAPpHfduFDXgu3VCCWSPiiv+RKp3igO4PqPJOy_+Vf7mU3_n6iQ@mail.gmail.com>
	<[email protected]>
	<CAPpHfdvYFxjsoRHiQb=pVoYuFogyw4Wd2W0f-c0sFwNLehmbbw@mail.gmail.com>
	<CAPpHfdtkn=Q3JicCgoubDuty9f+V36=4zEsTSCVqE71XiwS8pQ@mail.gmail.com>
	<[email protected]>
	<CAPpHfdsQhwUrnB3of862j9RgHoJM--eRbifvBMvtQxpC57dxCA@mail.gmail.com>
	<CAKNkYnxKgjLaQrbJaxqvS_bdvVVZ6Ty9ihGWL5b6sEFCAshJtw@mail.gmail.com>
	<CAPpHfdtQHpr6aMALxRmB+6SGBsYWVdTim9iW+zJtUjjU1L2CPQ@mail.gmail.com>
	<CACJufxHJ7ZRMbYgmsM3S3Tcw9UxMa7hE1S_1L3V9N-pVG=Te0A@mail.gmail.com>
	<CAPpHfdss4xOrAXD8bS+0nc2GyZBuNX=1QbgLwpjCLg4rzbbrhw@mail.gmail.com>
	<[email protected]>
	<CAPpHfdtj5yXgPiPJBenTLaFvBbF7U+LVpN=Eho1=o01jU_KQaA@mail.gmail.com>

On 21/10/2024 00:36, Alexander Korotkov wrote:
> On Thu, Oct 17, 2024 at 12:41 PM Andrei Lepikhov <[email protected]> wrote:
>> I think the first patch may already be committed, and this little burden
>> may be avoided in future versions.
> I've integrated your patch.  But I think
> finalize_in_progress_typentries() is more appropriate place to check
> typentry for NULL.  Also, I've revised the
> finalize_in_progress_typentries() header comment.  I'm going to push
> these patches if no objections.
I agree with your idea. Also, I think it would be more conventional not 
to check the type entry for a NULL value but to test the 'found' value 
instead.
And thanks for the injection points tests! I must have slipped my mind 
about this option.
Now, the patch set looks good for me.

-- 
regards, Andrei Lepikhov

view thread (32+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: type cache cleanup improvements
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox