From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PROPOSAL] Shared Ispell dictionaries
Date: Sat, 17 Mar 2018 02:29:31 +0100
Message-ID: <3c7910ba-2a1b-5b73-71c6-d037ba1e89bd@2ndquadrant.com> (raw)
In-Reply-To: <20180307131819.GA13301@zakirov.localdomain>
References: <20180302043149.tn2xjgt2vcigknhe@alap3.anarazel.de>
<20180307085553.GA5126@zakirov.localdomain>
<3195b6e6-4026-d7e2-ffa9-3780bc3cca6f@2ndquadrant.com>
<20180307115528.GA10093@zakirov.localdomain>
<CAFj8pRDOesYrROCDd-6YQzQcBQhZfD980zsGsfuu4NrRS-Gb1A@mail.gmail.com>
<20180307124353.GA12054@zakirov.localdomain>
<CAFj8pRDZOMQOmMhX4KSn+KTXbdB24ZaJxTxnYCHms_ya2Z2cOQ@mail.gmail.com>
<20180307125847.GA12617@zakirov.localdomain>
<CAFj8pRB=FWzq=FfoSPeoJfXG4a7P0Abp+0XKmet3E34tiuTUFA@mail.gmail.com>
<CAFj8pRDm9nhZCf16XDer-eeciqy0wipR0Y4+ZdwGMAWuv-k6ag@mail.gmail.com>
<20180307131819.GA13301@zakirov.localdomain>
On 03/07/2018 02:18 PM, Arthur Zakirov wrote:
> On Wed, Mar 07, 2018 at 02:12:32PM +0100, Pavel Stehule wrote:
>> 2018-03-07 14:10 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:
>>> 2018-03-07 13:58 GMT+01:00 Arthur Zakirov <a.zakirov@postgrespro.ru>:
>>>> Oh understood. Tomas suggested those commands too earlier. I'll
>>>> implement them. But I think it is better to track files modification time
>>>> too. Because now, without the patch, users don't have to call additional
>>>> commands to refresh their dictionaries, so without such tracking we'll
>>>> made dictionaries maintenance harder.
>>>>
>>>
>>> Postgres hasn't any subsystem based on modification time, so
>>> introduction this sensitivity, I don't see, practical.
>>>
>>
>> Usually the shared dictionaries are used for complex language
>> based fulltext. The frequence of updates of these dictionaries is
>> less than updates PostgreSQL. The czech dictionary is same 10
>> years.
>
> Agree. In this case auto reloading isn't important feature here.
>
Arthur, what are your plans with this patch in the current CF?
It does not seem to be moving towards RFC very much, and reworking the
patch to use mmap() seems like a quite significant change late in the
CF. Which means it's likely to cause the patch get get bumped to the
next CF (2018-09).
FWIW I am not quite sure if the mmap() approach is better than what was
implemented by the patch. I'm not sure how exactly will it behave under
memory pressure (AFAIK it goes through page cache, which means random
parts of dictionaries might get evicted) or how well is it supported on
various platforms (say, Windows).
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, a.zakirov@postgrespro.ru, pavel.stehule@gmail.com, andres@anarazel.de, i.kurbangaliev@postgrespro.ru
Subject: Re: [PROPOSAL] Shared Ispell dictionaries
In-Reply-To: <3c7910ba-2a1b-5b73-71c6-d037ba1e89bd@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox