From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Jeff Davis <pgsql@j-davis.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: bossartn@amazon.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().
Date: Tue, 26 Oct 2021 23:32:00 +0900
Message-ID: <3c7e03db-b55a-52b7-3512-be9a35d660aa@oss.nttdata.com> (raw)
In-Reply-To: <66fbd8a7b7b0037c9e1df48b41941aa587c67f4d.camel@j-davis.com>
References: <e5cf6684d17c8d1ef4904ae248605ccd6da03e72.camel@j-davis.com>
<33F34F0C-BB16-48DE-B125-95D340A54AE8@amazon.com>
<d87b3a4fa3dacb103a8f3f50751ec9e638b2e2b1.camel@j-davis.com>
<20211025.115333.563958443822411952.horikyota.ntt@gmail.com>
<ab46bf8a5158d27cdbb6901f49a6e38dd23e619e.camel@j-davis.com>
<YXZYVw7JF0mNtPue@paquier.xyz>
<66fbd8a7b7b0037c9e1df48b41941aa587c67f4d.camel@j-davis.com>
On 2021/10/26 5:42, Jeff Davis wrote:
> On Mon, 2021-10-25 at 16:10 +0900, Michael Paquier wrote:
>> Hmm. Why don't you split the patch into two parts that can be
>> discussed separately then? There would be one to remove all the
>> superuser() checks you can think of, and a potential second to grant
>> those function's execution to some system role.
>
> Good idea. Attached a patch to remove the superuser check on
> pg_log_backend_memory_contexts(), except in the case when trying to log
> memory contexts of a superuser backend.
- Only superusers can request to log the memory contexts.
+ Only superusers can request to log the memory contexts of superuser
+ backends.
The description "This function is restricted to superusers by default,
but other users can be granted EXECUTE to run the function."
should be added into the docs?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, pgsql@j-davis.com, michael@paquier.xyz, horikyota.ntt@gmail.com, bossartn@amazon.com
Subject: Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().
In-Reply-To: <3c7e03db-b55a-52b7-3512-be9a35d660aa@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox