pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: Andreas Karlsson <andreas@proxel.se>
To: pgsql-hackers@postgresql.org
Subject: Re: Collation & ctype method table, and extension hooks
Date: Wed, 04 Dec 2024 16:21:34 -0800
Message-ID: <3ddb0e4d402da295f8dff52e12ab906bbaa5de2b.camel@j-davis.com> (raw)
In-Reply-To: <4548a168-62cd-457b-8d06-9ba7b985c477@proxel.se>
References: <2830211e1b6e6a2e26d845780b03e125281ea17b.camel@j-davis.com>
	<e9cb235c-c820-49c2-a89e-ab38d7910a54@proxel.se>
	<fecea00b4ad9b9a2426cc34e78f30a0c75406ca7.camel@j-davis.com>
	<59da7ee4-5e1a-4727-b464-a603c6ed84cd@proxel.se>
	<dfff1ca84dd0e8ee03aa2478412134895b0b9681.camel@j-davis.com>
	<247f18f3-09e5-480d-9222-9d0d9684995f@proxel.se>
	<78a1b434ff40510dc5aaabe986299a09f4da90cf.camel@j-davis.com>
	<4548a168-62cd-457b-8d06-9ba7b985c477@proxel.se>

On Mon, 2024-12-02 at 16:39 +0100, Andreas Karlsson wrote:
> My patches:
> 
> = v9-0002-Move-check-for-ucol_strcollUTF8-to-pg_locale_icu..patch

Committed.

> = v9-0003-Move-code-for-collation-version-into-provider-spe.patch
> 
> Moves some code from pg_collate.c into provider specific files.

I agree with the general idea, but it seems we are accumulating a lot
of provider-specific functions. Should we define a provider struct with
its own methods?

That would be a good step toward making the provider catalog-driven.
Even if we don't support CREATE LOCALE PROVIDER, having space in the
catalog would be a good place to track the provider version.

> = v9-0004-Move-ICU-database-encoding-check-into-validation-.patch

This seems to be causing a test failure in 020_createdb.pl.

> = v9-0005-Move-provider-specific-code-when-looking-up-local.patch
> 
> I did not like how namespace.c had knowledge of ICU.

See comments above about v9-0003.

Regards,
	Jeff Davis






view thread (24+ messages)  latest in thread

Message-ID: <3ddb0e4d402da295f8dff52e12ab906bbaa5de2b.camel@j-davis.com>
Permalink:  ../3ddb0e4d402da295f8dff52e12ab906bbaa5de2b.camel@j-davis.com/
Also on:    postgresql.org/message-id/3ddb0e4d402da295f8dff52e12ab906bbaa5de2b.camel@j-davis.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pgsql@j-davis.com, andreas@proxel.se
  Subject: Re: Collation & ctype method table, and extension hooks
  In-Reply-To: <3ddb0e4d402da295f8dff52e12ab906bbaa5de2b.camel@j-davis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox