pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Stephen Frost <sfrost@snowman.net>
To: Noah Misch <noah@leadboat.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Date: Mon, 8 May 2017 11:05:52 +0900
Message-ID: <3e2aa1e9-e621-9ad5-b24d-e24dbc9650ba@lab.ntt.co.jp> (raw )
In-Reply-To: <CAOuzzgpmP8uDmqh9ekwR2VUakm_9=B1X6vyyZK+xazwK+s1Hug@mail.gmail.com >
References: <9b7baae3-21b5-a730-1ec4-aee290d54518@lab.ntt.co.jp >
<20170425154247.GJ9812@tamriel.snowman.net >
<5cdfd834-695a-9c05-8fb4-cde08de21a9b@lab.ntt.co.jp >
<20170426143157.GA21223@tamriel.snowman.net >
<47e1d272-8ce0-dea8-2bb5-642efa95c337@lab.ntt.co.jp >
<20170427141726.GF21223@tamriel.snowman.net >
<696c2d04-80aa-57e2-c1c5-6df25e2bbed5@lab.ntt.co.jp >
<20170503030520.GR21223@tamriel.snowman.net >
<CA+HiwqFn=iGV_sg53CtX+kqmNGm7vdT7sbgzTNOfJ5w=O4H5zg@mail.gmail.com >
<20170504214702.GP21223@tamriel.snowman.net >
<20170506031749.GD843225@rfd.leadboat.com >
<CAOuzzgpmP8uDmqh9ekwR2VUakm_9=B1X6vyyZK+xazwK+s1Hug@mail.gmail.com >
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Hi Stephen,
On 2017/05/06 12:28, Stephen Frost wrote:
> Noah,
>
> On Fri, May 5, 2017 at 23:19 Noah Misch <noah@leadboat.com> wrote:
>
>> On Thu, May 04, 2017 at 05:47:02PM -0400, Stephen Frost wrote:
>>> * Amit Langote (amitlangote09@gmail.com) wrote:
>>>> On Wed, May 3, 2017 at 12:05 PM, Stephen Frost <sfrost@snowman.net>
>> wrote:
>>>>> Assuming this looks good to you, I'll push it tomorrow, possibly with
>>>>> other minor adjustments and perhaps a few more tests.
>>>>
>>>> Your latest patch looks good to me.
>>>
>>> Found a few more issues (like pg_dump not working against older versions
>>> of PG, because the queries for older versions hadn't been adjusted) and
>>> did a bit more tidying.
>>>
>>> I'll push this in a couple of hours.
>>
>> This PostgreSQL 10 open item is past due for your status update. Kindly
>> send
>> a status update within 24 hours, and include a date for your subsequent
>> status
>> update. Refer to the policy on open item ownership:
>>
>> https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com
>>
>> I see you did commit a related patch. Is this item done?
>
>
> Yes, I believe it to be. I anticipate reviewing the code in this area more
> in the coming weeks, but this specific issue can be marked as resolved.
Thanks for committing the patch after improving it quite a bit, and sorry
that I couldn't reply promptly during the last week due to vacation.
Regards,
Amit
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
view thread (64+ messages) latest in thread
Message-ID: <3e2aa1e9-e621-9ad5-b24d-e24dbc9650ba@lab.ntt.co.jp>
Permalink: ../3e2aa1e9-e621-9ad5-b24d-e24dbc9650ba@lab.ntt.co.jp/
Also on: postgresql.org/message-id/3e2aa1e9-e621-9ad5-b24d-e24dbc9650ba@lab.ntt.co.jp
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: Langote_Amit_f8@lab.ntt.co.jp, sfrost@snowman.net, noah@leadboat.com, amitlangote09@gmail.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
In-Reply-To: <3e2aa1e9-e621-9ad5-b24d-e24dbc9650ba@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox