agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Nikolay Shaplov <dhyan@nataraj.su>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
To: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: Chris Travers <chris.travers@gmail.com>
To: Timur Magomedov <t.magomedov@postgrespro.ru>
Subject: Re: [PATCH] ternary reloption type
Date: Sun, 14 Sep 2025 11:49:34 +0300
Message-ID: <4047390.3Lj2Plt8kZ@thinkpad-pgpro> (raw)
In-Reply-To: <a48feb0829f4eb3e7b39b6de114e610935859580.camel@postgrespro.ru>
References: <3474141.usfYGdeWWP@thinkpad-pgpro>
<11330814.CDJkKcVGEf@thinkpad-pgpro>
<a48feb0829f4eb3e7b39b6de114e610935859580.camel@postgrespro.ru>
В письме от пятница, 12 сентября 2025 г. 16:46:19 MSK пользователь Timur
Magomedov написал:
> Hello Nikolay!
>
> Found a typo in reloptions.h, treaed -> treated.
Oups. Fixed that in the attached version.
> Can ternary enum be added in a separate header file, say,
> src/include/ternary.h instead of adding it to c.h? I'm just not sure if
> c.h is it the right place for relation-options-specific code.
> Of course, I can be wrong.
I am not sure either. But my guess is that spamming into c.h is lesser crime
then adding another useless header file.
Moreover, ternary value is not relation-options-specific, it is actually
relation specific, if you think about it thoroughly. Relation code uses it, and
there is no way to avoid that.
Are there any other notions about the code?
I tried to make thongs more neat and more consistent here. Did I succeed?
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
Attachments:
[text/x-patch] v2a-0001-Add-ternary-reloption-type.patch (0B, ../4047390.3Lj2Plt8kZ@thinkpad-pgpro/2-v2a-0001-Add-ternary-reloption-type.patch)
download
view thread (13+ messages) latest in thread
Message-ID: <4047390.3Lj2Plt8kZ@thinkpad-pgpro>
Permalink: ../4047390.3Lj2Plt8kZ@thinkpad-pgpro/
Also on: postgresql.org/message-id/4047390.3Lj2Plt8kZ@thinkpad-pgpro
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dhyan@nataraj.su, pgsql-hackers@lists.postgresql.org, alvherre@alvh.no-ip.org, chris.travers@gmail.com, t.magomedov@postgrespro.ru
Subject: Re: [PATCH] ternary reloption type
In-Reply-To: <4047390.3Lj2Plt8kZ@thinkpad-pgpro>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox