From: Dennis Haney <davh@diku.dk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: IN joining
Date: Mon, 08 Mar 2004 17:04:48 +0100
Message-ID: <404C99A0.7050808@diku.dk> (raw)
In-Reply-To: <4062.1078760645@sss.pgh.pa.us>
References: <4048B8D6.70401@diku.dk>
<11205.1078520699@sss.pgh.pa.us>
<4048F1D3.20405@diku.dk>
<12170.1078528135@sss.pgh.pa.us>
<404C7D3C.50908@diku.dk>
<4062.1078760645@sss.pgh.pa.us>
Tom Lane wrote:
[SNIP: a repetion of my first post ;) ]
>I think it should be
>
> /*
> * If we already joined IN's RHS to anything else in
> * either input path, then this join is not constrained (the
> * necessary work was done at a lower level).
> */
> if (bms_is_subset(ininfo->righthand, rel1->relids) &&
> !bms_equal(ininfo->righthand, rel1->relids))
> continue;
> if (bms_is_subset(ininfo->righthand, rel2->relids) &&
> !bms_equal(ininfo->righthand, rel2->relids))
> continue;
>
>Comments?
>
>
It's good.
It was pretty much what I was thinking was wrong to begin with.
Whether the generated plans are valid is a different issue ;)
--
Dennis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: davh@diku.dk, tgl@sss.pgh.pa.us
Subject: Re: IN joining
In-Reply-To: <404C99A0.7050808@diku.dk>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox