pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_restore -N loses extension comment
Date: Tue, 07 May 2024 09:52:49 -0400
Message-ID: <4054893.1715089969@sss.pgh.pa.us> (raw)
In-Reply-To: <ZjoeirG7yxODdC4P@pryzbyj2023>
References: <ZjoeirG7yxODdC4P@pryzbyj2023>

Justin Pryzby <pryzby@telsasoft.com> writes:
> pg_dump -Fc |pg_restore -l -N schema:
> | 2; 3079 18187 EXTENSION - pg_buffercache 
> Without -N schema also shows:
> | 2562; 0 0 COMMENT - EXTENSION pg_buffercache 

Hmm, but what happens if you actually do the restore?

I think this may be a bug in -l mode: ProcessArchiveRestoreOptions
saves the result of _tocEntryRequired in te->reqs, but PrintTOCSummary
doesn't, and that will bollix its subsequent _tocEntryRequired checks
for "dependent" TOC entries.

			regards, tom lane





view thread (3+ messages)  latest in thread

Message-ID: <4054893.1715089969@sss.pgh.pa.us>
Permalink:  ../4054893.1715089969@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/4054893.1715089969@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pryzby@telsasoft.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_restore -N loses extension comment
  In-Reply-To: <4054893.1715089969@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox