pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: bug when apply fast default mechanism for adding new column over domain with default value
Date: Mon, 03 Mar 2025 13:38:38 -0500
Message-ID: <4060266.1741027118@sss.pgh.pa.us> (raw)
In-Reply-To: <3664075.1741018726@sss.pgh.pa.us>
References: <CACJufxHFssPvkP1we7WMhPD_1kwgbG52o=kQgL+TnVoX5LOyCQ@mail.gmail.com>
	<2901599.1740811424@sss.pgh.pa.us>
	<CACJufxG97GWGC3kczph04JjLHKGDMH4oVou1_yXKHxFSqAHwBQ@mail.gmail.com>
	<3086966.1740873261@sss.pgh.pa.us>
	<CACJufxFQkAwZ-VpFX4ZYHqi0PPL4RMfB4Zp=8At=oF-zgBX4yA@mail.gmail.com>
	<3519325.1740953319@sss.pgh.pa.us>
	<CACJufxE9Ey=M_gpDpXFwur5g+CcXv-ZM0aSZPc+SCk0MqngstA@mail.gmail.com>
	<3664075.1741018726@sss.pgh.pa.us>

I wrote:
> jian he <jian.universality@gmail.com> writes:
>> within ATExecAddColumn, we can
>>     if (!missingIsNull)
>>         StoreAttrMissingVal(rel, attribute->attnum, missingval, missingIsNull);
>> to save some cycles?

> Probably not really worth it: surely that's going to be a very
> infrequent edge case.

On second thought, it is worth doing like that, not on speed
grounds but because we can make StoreAttrMissingVal simpler
by not handling the is-null case at all.

Pushed with that adjustment and some other minor polishing.

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <4060266.1741027118@sss.pgh.pa.us>
Permalink:  ../4060266.1741027118@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/4060266.1741027118@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jian.universality@gmail.com
  Subject: Re: bug when apply fast default mechanism for adding new column over domain with default value
  In-Reply-To: <4060266.1741027118@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox