public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ilia Evdokimov <[email protected]>
To: Sami Imseih <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Greg Sabino Mullane <[email protected]>
Cc: Andrey Borodin <[email protected]>
Cc: Alena Rybakina <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Sample rate added to pg_stat_statements
Date: Wed, 26 Feb 2025 13:51:13 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA5RZ0trJoVqGmELHOc=G2SxHQHKdTb1aAvzf3vHdfVP8UH+Xg@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CAA5RZ0s+khQ_u84qS_cAHzxVQQHK_UmWXxRBWTTex7zW1250tQ@mail.gmail.com>
<[email protected]>
<CAA5RZ0vxn_UiUkUK5SdngObLZzw40RhafB7SHydxzBw2_xjjiA@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CAA5RZ0tJjrX6YiQVDZCOA_BDMuhO-po_T8a3PmjxEEH_iL-qMg@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CAA5RZ0vz+Abyck0dn0fHJ5nTfJU7wdLRxfUj481Ga-BGNY0Txg@mail.gmail.com>
<[email protected]>
<CAA5RZ0trJoVqGmELHOc=G2SxHQHKdTb1aAvzf3vHdfVP8UH+Xg@mail.gmail.com>
On 20.02.2025 03:32, Sami Imseih wrote:
>> As you can see, the query has not been normalized. Is it a bug, expected or undefined behavior?
> No, this behavior is expected. The ability to normalize a statement is
> only available
> during post_parse_analyze (pgss_post_parse_analyze), as this is when
> we have access to
> JumbleState.
>
> In your example, pgss_post_parse_analyze is skipped and during the
> subsequent \bind_named,
> ExecutorEnd (pgss_ExecutorEnd) does not have access to JumbleState,
> leading to the query to be stored without normalization.
>
> It will be nice to make JumbleState available to all hooks, IMO.
>
> --
> Sami
Got it. I think it's worth considering, but not within the scope of this
thread.
--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.
view thread (58+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Sample rate added to pg_stat_statements
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox