pg.ddx.io pgsql-hackers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Oleg Bartunov <obartunov@postgrespro.ru>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Stas Kelvich <s.kelvich@postgrespro.ru>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: David Steele <david@pgmasters.net>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Subject: Re: jsonpath
Date: Mon, 28 Jan 2019 21:28:48 -0500
Message-ID: <4139.1548728928@sss.pgh.pa.us> (raw)
In-Reply-To: <20190129015927.yyywhbt57xwvux7n@alap3.anarazel.de>
References: <CAPpHfdtxOuEu4t-uGwJF9qzusAmViBf_e3cLYUx1mEoqwWD21g@mail.gmail.com>
<CAPpHfdu4nKqccH0tE84fTJqc7qV-9_w_uic1_zGTYY4FEbQUOw@mail.gmail.com>
<CAPpHfduk=0DOKa40A+0Gi-eo03on_7DZgLZV9vNGdgfUMF_v2w@mail.gmail.com>
<CAPpHfdv+YtPtmircv0kDNH8t9CJ2u8NVGT0JMOxxG2Tdi9BAYg@mail.gmail.com>
<eebc218c-7aaa-c425-6ba0-78b28c751830@2ndquadrant.com>
<9f5f1247-29f4-17cd-edd9-38e9bcd95b14@postgrespro.ru>
<CAPpHfdsxacOREFDAhhZFwL=-x8Z49LCrEK8T9Zn=SJY-EJ+S_Q@mail.gmail.com>
<20190129010332.i4t64evqc3bwtjzx@alap3.anarazel.de>
<CAPpHfdusVmROP2PepYs2ZV6six9hQ2mzqDpKP9jWX2vi7aSU-Q@mail.gmail.com>
<20190129013115.btqiip2leypmuf3n@alap3.anarazel.de>
<20190129015927.yyywhbt57xwvux7n@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> And even if you, to address Tom's point about plpgsql, had a category
> that could only be thrown by core code,
Actually, that wasn't quite what my point was there. Even if the error
that is thrown is perfectly safe and was thrown from a known spot in the
core code, elog.c will call ErrorContextCallback functions on the way out,
*before* longjmp'ing back to your code. So, if PL foo executes a SQL
command that includes jsonpath operations, it's possible for PL foo's
error context reporting code to break whatever assumptions you thought
were safe to make.
Admittedly, a wise PL designer would refrain from assuming too much about
what they can get away with doing in an error context callback. But
that very same caution should persuade us not to assume too much about
what actually has happened during error processing.
regards, tom lane
view thread (198+ messages) latest in thread
Message-ID: <4139.1548728928@sss.pgh.pa.us> Permalink: ../4139.1548728928@sss.pgh.pa.us/ Also on: postgresql.org/message-id/4139.1548728928@sss.pgh.pa.us ·
reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Reply to all the recipients using the --to and --cc options: reply via email To: pgsql-hackers@postgresql.org Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, a.korotkov@postgrespro.ru, n.gluhov@postgrespro.ru, tomas.vondra@2ndquadrant.com, obartunov@postgrespro.ru, michael@paquier.xyz, s.kelvich@postgrespro.ru, thomas.munro@enterprisedb.com, david@pgmasters.net, andrew.dunstan@2ndquadrant.com, robertmhaas@gmail.com, pavel.stehule@gmail.com Subject: Re: jsonpath In-Reply-To: <4139.1548728928@sss.pgh.pa.us> * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox