pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Yura Sokolov <y.sokolov@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Add PortalDrop in exec_execute_message
Date: Fri, 21 May 2021 14:23:20 -0400
Message-ID: <4160143.1621621400@sss.pgh.pa.us> (raw)
In-Reply-To: <4aa370cb91ecf2f9885d98b80ad1109c@postgrespro.ru>
References: <4aa370cb91ecf2f9885d98b80ad1109c@postgrespro.ru>

Yura Sokolov <y.sokolov@postgrespro.ru> writes:
> I propose to add PortalDrop at the 'if (completed)' branch of
> exec_execute_message.

This violates our wire protocol specification, which
specifically says

    If successfully created, a named portal object lasts till the end of
    the current transaction, unless explicitly destroyed. An unnamed
    portal is destroyed at the end of the transaction, or as soon as the
    next Bind statement specifying the unnamed portal as destination is
    issued. (Note that a simple Query message also destroys the unnamed
    portal.)

I'm inclined to think that your complaint would be better handled
by having the client send a portal-close command, if it's not
going to do something else immediately.

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <4160143.1621621400@sss.pgh.pa.us>
Permalink:  ../4160143.1621621400@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/4160143.1621621400@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, y.sokolov@postgrespro.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: Add PortalDrop in exec_execute_message
  In-Reply-To: <4160143.1621621400@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox