From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: strange result from contrib/seg regression on windows
Date: Sun, 17 Oct 2004 17:44:56 -0400
Message-ID: <4172E7D8.1000403@dunslane.net> (raw)
In-Reply-To: <10333.1098042565@sss.pgh.pa.us>
References: <4172C96E.6060008@dunslane.net>
<10333.1098042565@sss.pgh.pa.us>
Tom Lane wrote:
>Andrew Dunstan <andrew@dunslane.net> writes:
>
>
>>Does anyone have a clue why?
>>
>>
>
>Evidently your sscanf isn't setting errno for overflow --- look at
>seg_atof() in segparse.y.
>
>
>This code shows several other signs of severe brain death, actually,
>like leaking 256 bytes on each call for an error message buffer that it
>doesn't even need :-( I'd recommend ripping the whole thing out and
>replacing with a call to float4in.
>
>
>
>
Yeah. If anyone can do this quickly I'd be grateful. Otherwise it will
probably be a few days before I get it done.
Alternatively, could we not just use strtof instead of sscanf?
cheers
andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@dunslane.net, tgl@sss.pgh.pa.us
Subject: Re: strange result from contrib/seg regression on windows
In-Reply-To: <4172E7D8.1000403@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox