public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Andrey V. Lepikhov <[email protected]>
Cc: Dmitry Dolgov <[email protected]>
Cc: Zhihong Yu <[email protected]>
Cc: David Steele <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Greg Stark <[email protected]>
Cc: Pavel Trukhanov <[email protected]>
Subject: Re: pg_stat_statements and "IN" conditions
Date: Wed, 05 Jan 2022 00:13:30 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <20201226104635.uvzkftzu72zg5qux@localhost>
<CALNJ-vQx7u-Nq_wVun72CVrHe4DcGfEurj_ikckJrRy2Pem=JA@mail.gmail.com>
<20210105125230.etgmgixnn6fmpszl@localhost>
<CALNJ-vRRrdXu9igzh5PFTBghK5hnQWF6gpntTPo_+Agq_TsT5Q@mail.gmail.com>
<[email protected]>
<20210318155002.ggrgf2p2mvaodcox@localhost>
<20210615151850.6nsue7z5xjhpytle@localhost>
<20210616140212.kt3n5wi3alfz5i5d@localhost>
<20210930134930.d4vzwhvxhfpk2zxt@localhost>
<CALNJ-vSJvaJbcXr46JMyWFT5rO3BdaHO2E=xnAbLNDw1cyUJ-A@mail.gmail.com>
<20210930150957.tz3h3unjyrzatw6e@localhost>
<[email protected]>
<[email protected]>
"Andrey V. Lepikhov" <[email protected]> writes:
> On 1/5/22 4:02 AM, Tom Lane wrote:
>> I've been saying from day one that pushing the query-hashing code into the
>> core was a bad idea, and I think this patch perfectly illustrates why.
> +1.
> Let me suggest, that the core should allow an extension at least to
> detect such interference between extensions. Maybe hook could be
> replaced with callback to allow extension see an queryid with underlying
> generation logic what it expects.
I feel like we need to get away from the idea that there is just
one query hash, and somehow let different extensions attach
differently-calculated hashes to a query. I don't have any immediate
ideas about how to do that in a reasonably inexpensive way.
regards, tom lane
view thread (12+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pg_stat_statements and "IN" conditions
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox