public inbox for [email protected]  
help / color / mirror / Atom feed
From: Chao Li <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Kirill Reshke <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes
Date: Tue, 12 May 2026 10:31:05 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>



> On May 12, 2026, at 00:21, Álvaro Herrera <[email protected]> wrote:
> 
> On 2026-May-11, Chao Li wrote:
> 
>>> On May 10, 2026, at 06:38, Álvaro Herrera <[email protected]> wrote:
> 
>>> I think it would be a good idea to make identity_key_equal() not deform
>>> all attributes, but instead only up to the last one it needs for the key
>>> comparisons.
>> 
>> That’s true. Please see v3.
> 
> Thanks.  I did one further small change, namely to determine these last
> attnums just once per run rather than once per tuple.  Pushed now.
> 
> Thanks for testing!
> 
> -- 
> Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

Hi Álvaro, thank you so much for tuning the code and pushing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/









view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox