pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
To: vignesh C <vignesh21@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Yu Shi (Fujitsu) <shiy.fnst@fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add two missing tests in 035_standby_logical_decoding.pl
Date: Fri, 5 May 2023 09:18:04 +0200
Message-ID: <41fc4bff-e733-1bb8-8ae8-37a4b8ab920e@gmail.com> (raw )
In-Reply-To: <CALDaNm3vFw3oXqYcqrL_UUJprHA-1Hhi-4kkKPLvz274tHaGWg@mail.gmail.com >
References: <2fefa454-5a70-2174-ddbf-4a0e41537139@gmail.com >
<CAA4eK1JeAZ9MUf3qPAOA5t9=e_vPJSEi6nZ3OygDYi-913eO+Q@mail.gmail.com >
<74f80bc1-6b39-b2a8-c716-98beefb75e0b@gmail.com >
<OSZPR01MB6310F24417BDD04731BD7978FD659@OSZPR01MB6310.jpnprd01.prod.outlook.com >
<17b6b056-4f53-c444-0c94-869547d1a5df@gmail.com >
<CAA4eK1JiYisk1aqn1uvjd+VCfsVtXLby7uMmkLQU_ggAx7xt6w@mail.gmail.com >
<054defef-de15-53e4-6c5a-d16ccc21d4ba@gmail.com >
<CAA4eK1LEQfC-ZxOkN4=cuAxB1N=2iLcEEb+Mb=XGCqGhwvMkaA@mail.gmail.com >
<8a13f0d8-71f3-773b-7135-5974fd53724b@gmail.com >
<CAA4eK1+FhvUm6w-TYqXAAMNDPZcin05pyCu7Lzn-AnafFYYhBg@mail.gmail.com >
<CALDaNm3GOW-7DfdqUiJADhEmQNQkFA+OonV4kvKkZcbK=0yr5w@mail.gmail.com >
<CAA4eK1La2uVZdSNdp_AwpxVP85SvWHMT3ecfJgVYqPMjGVViyw@mail.gmail.com >
<6711e200-0d5c-98c3-ba39-7d64a6936f7a@gmail.com >
<CAA4eK1LQmnSroXZcR+w1JuHsOyQLdj=-QWUw8ExYem3kUpBE3A@mail.gmail.com >
<CALDaNm3vFw3oXqYcqrL_UUJprHA-1Hhi-4kkKPLvz274tHaGWg@mail.gmail.com >
Hi,
On 5/5/23 9:11 AM, vignesh C wrote:
> On Fri, 5 May 2023 at 12:34, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>> On Fri, May 5, 2023 at 11:08 AM Drouvot, Bertrand
>> <bertranddrouvot.pg@gmail.com> wrote:
>>>
>>> On 5/4/23 6:43 AM, Amit Kapila wrote:
>>>> On Thu, May 4, 2023 at 8:37 AM vignesh C <vignesh21@gmail.com> wrote:
>>>>>
>>>>> Thanks for posting the updated patch, I had run this test in a loop of
>>>>> 100 times to verify that there was no failure because of race
>>>>> conditions. The 100 times execution passed successfully.
>>>>>
>>>>> One suggestion:
>>>>> "wal file" should be changed to "WAL file":
>>>>> +# Request a checkpoint on the standby to trigger the WAL file(s) removal
>>>>> +$node_standby->safe_psql('postgres', 'checkpoint;');
>>>>> +
>>>>> +# Verify that the wal file has not been retained on the standby
>>>>> +my $standby_walfile = $node_standby->data_dir . '/pg_wal/' . $walfile_name;
>>>>>
>>>>
>>>> Thanks for the verification. I have pushed the patch.
>>>>
>>>
>>> It looks like there is still something wrong with this test as there
>>> are a bunch of cfbot errors on this new test (mainly on macOS - Ventura - Meson).
>>>
>>
>> Is it possible for you to point me to those failures?
>
> I think these failures are occuring in CFBOT, once such instance is at:
> https://cirrus-ci.com/task/6642271152504832?logs=test_world#L39
> https://api.cirrus-ci.com/v1/artifact/task/6642271152504832/testrun/build/testrun/recovery/035_stand...
>
Yeah, thanks, that's one of them.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
view thread (57+ messages) latest in thread
Message-ID: <41fc4bff-e733-1bb8-8ae8-37a4b8ab920e@gmail.com>
Permalink: ../41fc4bff-e733-1bb8-8ae8-37a4b8ab920e@gmail.com/
Also on: postgresql.org/message-id/41fc4bff-e733-1bb8-8ae8-37a4b8ab920e@gmail.com
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bertranddrouvot.pg@gmail.com, vignesh21@gmail.com, amit.kapila16@gmail.com, shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Add two missing tests in 035_standby_logical_decoding.pl
In-Reply-To: <41fc4bff-e733-1bb8-8ae8-37a4b8ab920e@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox