public inbox for [email protected]  

help / color / mirror / Atom feed
From: Pavel Luzanov <[email protected]>
To: David G. Johnston <[email protected]>
Cc: David Zhang <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: psql: Add role's membership options to the \du+ command
Date: Fri, 10 Mar 2023 15:06:04 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKFQuwZTK7z=+rJkgbaZE=4H6FPxBJhbXBvKuR7e_vUXbPQEZw@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAKFQuwYt3ENZoYgY2RBh-U4id_=vntT9uJ83PvxPSsPQ0Cc_Jw@mail.gmail.com>
	<[email protected]>
	<CAKFQuwbmAFfDw9ScCiOxK4UGf8Z8ny1nDgAn41gOJCeJ76QC4Q@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAKFQuwYZ3S_A1ZKdnmOv-LueO1683UZf7AocNFTDjwEMLVfMOA@mail.gmail.com>
	<[email protected]>
	<CAKFQuwbkywHVFPL6TrJiHFd0KgEvdH0LZTSFxAdK4wzP-u8m-A@mail.gmail.com>
	<[email protected]>
	<CAKFQuwY9DtC8B-eCpHe39yK+y9LardAyaEz0ccVa_pQ+xBgr2Q@mail.gmail.com>
	<[email protected]>
	<CAKFQuwb6u62n=eq2ZXq6mbVTpqWR2bz_QhmLjWrQ89Kcoi5x+g@mail.gmail.com>
	<CAKFQuwZTK7z=+rJkgbaZE=4H6FPxBJhbXBvKuR7e_vUXbPQEZw@mail.gmail.com>

On 08.03.2023 05:31, David G. Johnston wrote:
> Moving the goal posts for this meta-command to >= 9.5 seems like it 
> should be done as a separate patch and thread.  The documentation 
> presently states we are targeting 9.2 and newer.

I missed the comment at the beginning of the file about version 9.2. I 
will return the version check for rolbypassrls.

> My suggestion for the docs is below.

> +        <para>
> +        Shown within each row, in newline-separated format, are the 
> memberships granted to
> +        the role.  The presentation includes both the name of the grantor
> +        as well as the membership permissions (in an abbreviated format:
> +        <literal>a</literal> for admin option, <literal>i</literal> 
> for inherit option,
> +        <literal>s</literal> for set option.) The word 
> <literal>empty</literal> is printed in
> +        the case that none of those permissions are granted.
> +        See the <link 
> linkend="sql-grant"><command>GRANT</command></link> command for their 
> meaning.
> +        </para>
> +        <para>
> +        If the form <literal>\dg+</literal> is used the comment 
> attached to the role is shown.
>          </para>

Thanks. I will replace the description with this one.

> I would suggest tweaking the test output to include regress_du_admin 
> and also to make regress_du_admin a CREATEROLE role with LOGIN.

Ok.

Thank you for review. I will definitely work on the new version, but 
unfortunately and with a high probability it will happen after March 20.

-- 
Pavel Luzanov
Postgres Professional:https://postgrespro.com


view thread (29+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: psql: Add role's membership options to the \du+ command
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox