public inbox for [email protected]
help / color / mirror / Atom feedFrom: Heikki Linnakangas <[email protected]>
To: Dagfinn Ilmari Mannsåker <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: [email protected]
Subject: Re: Better shared data structure management and resizable shared data structures
Date: Tue, 7 Apr 2026 16:26:16 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAExHW5vM1bneLYfg0wGeAa=52UiJ3z4vKd3AJ72X8Fw6k3KKrg@mail.gmail.com>
<[email protected]>
<CA+Tgmob8ot7qam7a650nx_4jyEoFLs8s_kPMc1+EB7-dr56=WA@mail.gmail.com>
<[email protected]>
<CA+TgmoauqYXm8iA3FGRAVKxYShUxWBiS_MSLmQpTrmO7wNHamw@mail.gmail.com>
<[email protected]>
<CAExHW5uTNWOSxJDWQAUnS0tZawob2_J3dRAtc67NHNZ98X4_xA@mail.gmail.com>
<CAExHW5t439y61YD9bc7d5wZWHp6J=M43Qu3eEZOBPguZML7o2A@mail.gmail.com>
<CAExHW5v5FVZbsO9sLzztMZ11C3hgGStE=HkkV2bQkCyncess4w@mail.gmail.com>
<[email protected]>
<CAExHW5tCC0T1ky=Jnq-AvMxa67Adaw7aQ4iQAO=BSdHcbSNBVg@mail.gmail.com>
<[email protected]>
<CAExHW5tS7GncN90oJWOSzW_3F1EHL9xwe59L7Req3nUVgmObUw@mail.gmail.com>
<[email protected]>
<CAExHW5sYgt=XekOoAE-Tu_Dv8obWZCjCqAPT9vtN2D4m=M=drQ@mail.gmail.com>
<[email protected]>
<[email protected]>
On 07/04/2026 15:24, Dagfinn Ilmari Mannsåker wrote:
> Heikki Linnakangas <[email protected]> writes:
>
>> Those are now committed, and here's a new version rebased over those
>> changes.
>
> I noticed this bit during my habitual morning skim of new commits:
>
>> diff --git a/src/backend/utils/misc/injection_point.c b/src/backend/utils/misc/injection_point.c
>> index c06b0e9b800..9981d6e212f 100644
>> --- a/src/backend/utils/misc/injection_point.c
>> +++ b/src/backend/utils/misc/injection_point.c
>> @@ -17,6 +17,7 @@
>> */
>> #include "postgres.h"
>>
>> +#include "storage/subsystems.h"
>> #include "utils/injection_point.h"
>>
>> #ifdef USE_INJECTION_POINTS
>> @@ -109,6 +110,11 @@ typedef struct InjectionPointCacheEntry
>>
>> static HTAB *InjectionPointCache = NULL;
>>
>> +#ifdef USE_INJECTION_POINTS
>> +static void InjectionPointShmemRequest(void *arg);
>> +static void InjectionPointShmemInit(void *arg);
>> +#endif
>> +
>
> This is already inside an `#ifdef USE_INJECTION_POINTS` guard (in fact
> visible at the end of the previous diff hunk), no need for another one.
Fixed, thanks. I also noticed that the #include "storage/subsystems.h"
can be moved inside the #ifdef block; fixed that too.
- Heikki
view thread (82+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Better shared data structure management and resizable shared data structures
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox