From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: SIGSEGV in BRIN autosummarize
Date: Wed, 18 Oct 2017 14:58:01 -0400
Message-ID: <4419.1508353081@sss.pgh.pa.us> (raw)
In-Reply-To: <20171018165409.2cznyyugvqigtktt@alvherre.pgsql>
References: <20171018165409.2cznyyugvqigtktt@alvherre.pgsql>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> And the previous code crashes in 45 minutes? That's solid enough for
> me; I'll clean up the patch and push in the next few days. I think what
> you have now should be sufficient for the time being for your production
> system.
I'm still of the opinion that the presented patch isn't preventing any
crashes. The failure to check avw_database would generally lead to
tasks silently getting dropped in the mistaken belief that the target
table has gone away. I could believe that a crash occurs if the given
schema OID exists in some other DB, and the given table OID does too,
but it's for a table/index of the wrong kind ... but how likely is that?
Not very likely at all, given the way we generate OIDs.
(And if it did happen, I'd say the cause is a failure to recheck relkind
somewhere downstream of the autovac task dispatch code, anyway.)
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, pryzby@telsasoft.com
Subject: Re: SIGSEGV in BRIN autosummarize
In-Reply-To: <4419.1508353081@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox