pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Anton A. Melnikov <a.melnikov@postgrespro.ru>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: daniel@yesql.se
Cc: peter@eisentraut.org
Cc: tgl@sss.pgh.pa.us
Cc: robertmhaas@gmail.com
Cc: michael@paquier.xyz
Cc: pgsql-hackers@postgresql.org
Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?
Date: Sat, 5 Apr 2025 22:10:02 +0300
Message-ID: <4419f57e-8af5-425a-aa98-a2f921162d37@postgrespro.ru> (raw)
In-Reply-To: <be2a0cf2-461d-4606-beea-b219c22ab8a6@oss.nttdata.com>
References: <54B16BF2-6979-4BB0-BE39-118D32B1BC58@yesql.se>
	<20240903.143756.562059416508617821.horikyota.ntt@gmail.com>
	<fc33823e-dbdf-4f31-b9aa-bf7f758019b9@postgrespro.ru>
	<20240904.170927.1051663922860738119.horikyota.ntt@gmail.com>
	<a131bf48-6d62-4b67-87e4-ff2c069350b2@postgrespro.ru>
	<359568e0-cffc-4f64-b84c-eee76ba229b8@postgrespro.ru>
	<2883bd25-f362-41ed-8d41-b6e0aac8fa27@postgrespro.ru>
	<18d80eb9-1e7a-4ead-98fe-60efc988954b@oss.nttdata.com>
	<cfaa1778-99f2-4348-8ab7-56be503e6d39@postgrespro.ru>
	<be2a0cf2-461d-4606-beea-b219c22ab8a6@oss.nttdata.com>

Hi!

On 05.04.2025 06:11, Fujii Masao wrote:
> 
> Thanks for checking! Barring any objections, I'll go ahead and commit the patch.
> 

As for me all is ok. Thanks!

>> Maybe extend this to perl tests since there are several hardcoded names too?
>> The patch attached tries to do this.
> 
> I had the same thought, i.e., we could use scan_server_header() to pull
> XLOG_CONTROL_FILE from xlog_internal.h and replace the hardcoded "global/pg_control"
> in the TAP tests. But for now, that feels like overkill, since the TAP tests already
> have other hardcoded values like the WAL directory (pg_wal), and we haven't used
> macros like XLOGDIR there either. Replacing just "global/pg_control" might feel
> inconsistent, and handling the other cases properly would take more time beyond
> feature freeze. So I'm thinking it's better to use XLOG_CONTROL_FILE only in
> C code for now.

Agreed. Also think that it is better to fix all such places at once and some later.


Best wishes!

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company





view thread (26+ messages)  latest in thread

Message-ID: <4419f57e-8af5-425a-aa98-a2f921162d37@postgrespro.ru>
Permalink:  ../4419f57e-8af5-425a-aa98-a2f921162d37@postgrespro.ru/
Also on:    postgresql.org/message-id/4419f57e-8af5-425a-aa98-a2f921162d37@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.melnikov@postgrespro.ru, masao.fujii@oss.nttdata.com, horikyota.ntt@gmail.com, daniel@yesql.se, peter@eisentraut.org, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, michael@paquier.xyz
  Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?
  In-Reply-To: <4419f57e-8af5-425a-aa98-a2f921162d37@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox