pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Adding CI to our tree
Date: Tue, 18 Jan 2022 23:39:20 -0500
Message-ID: <449909.1642567160@sss.pgh.pa.us> (raw)
In-Reply-To: <20220119041646.rhuo3youiqxqjmo2@alap3.anarazel.de>
References: <20220114235457.GQ14051@telsasoft.com>
	<87a81b91-87bf-c0bc-7e4f-06dffadcf737@dunslane.net>
	<20220117181946.bmvubqpzqxlvmgeh@alap3.anarazel.de>
	<CA+Tgmoap6WXzta=zw97SF73hCfzEWVMtfDFB01svYXMtTzKVVA@mail.gmail.com>
	<20220117192510.txue5mihjaxlngep@alap3.anarazel.de>
	<85428.1642447853@sss.pgh.pa.us>
	<20220117201619.3ltudwhgk2krmoki@alap3.anarazel.de>
	<20220118210847.GC23027@telsasoft.com>
	<20220119011626.nw5cvugqfsy3fyob@alap3.anarazel.de>
	<440239.1642560607@sss.pgh.pa.us>
	<20220119041646.rhuo3youiqxqjmo2@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-01-18 21:50:07 -0500, Tom Lane wrote:
>> There is no reason for this script to be overriding Cluster.pm's
>> fsync = off setting.
>> This appears to go back to 917dc7d23 of 2016, so I think it just
>> predates our recognition that we should disable fsync in routine
>> tests.

> Yea, I noticed this too. I was wondering if there's a conceivable reason to
> actually want fsyncs, but I couldn't come up with one.

On the one hand, it feels a little wrong if our test suites never
reach our fsync calls at all.  On the other hand, it's not clear
what is meaningful about testing fsync when your test scenario
doesn't include a plug pull.

I'd be okay with having some exercise of the fsync code paths in
a test that is (a) designated for the purpose and (b) arranged
to not take an excessive amount of time, even under heavy load.
008_fsm_truncation.pl is neither of those things.  It seems
entirely random that it has fsync = on when we don't test that
elsewhere.

			regards, tom lane





view thread (142+ messages)  latest in thread

Message-ID: <449909.1642567160@sss.pgh.pa.us>
Permalink:  ../449909.1642567160@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/449909.1642567160@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pryzby@telsasoft.com, robertmhaas@gmail.com, andrew@dunslane.net, thomas.munro@gmail.com, melanieplageman@gmail.com, peter.eisentraut@enterprisedb.com, daniel@yesql.se
  Subject: Re: Adding CI to our tree
  In-Reply-To: <449909.1642567160@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox