pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Petr Jelinek <petr@2ndquadrant.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: adding partitioned tables to publications
Date: Fri, 3 Apr 2020 16:43:17 +0200
Message-ID: <44ecae53-9861-71b7-1d43-4658acc52519@2ndquadrant.com> (raw)
In-Reply-To: <CA+HiwqGkknVb+ccLVkgw1DoBYPzpuR43L+aT1eOT8dVEtiedtw@mail.gmail.com>
References: <CA+HiwqH=Y85vRK3mOdjEkqFK+E=ST=eQiHdpj43L=_eJMOOznQ@mail.gmail.com>
	<CA+HiwqFjo=vCXDdkwprf6ipaVeegCpW79n-Ds8BK5cNQsSey2A@mail.gmail.com>
	<d760bb60-563c-dd01-9903-f9337d50e8a6@2ndquadrant.com>
	<CA+HiwqFBni-cXy5NBN0PdwxidXgcCEio0N_AOnOM0pR2dMWUyA@mail.gmail.com>
	<CA+HiwqGVbp0yh-7-FscZiYu1B_CJjaDZRTYkPTjnjpUgSzE6RA@mail.gmail.com>
	<b8f257af-3fcd-65b9-088c-0248d82e4e99@2ndquadrant.com>
	<CA+HiwqFZbbJzAZgTjqbRarp_xeqyymuNmGg8Q5tDKTZbk3=c2A@mail.gmail.com>
	<c0d69728-c3d8-ede8-ad31-941b2bbaff66@2ndquadrant.com>
	<CA+HiwqE+6gNgr-BVYeCMT38naRi9cJaanJb7+FCNsX9XgMwHsQ@mail.gmail.com>
	<CA+HiwqFjYE5anArxvkjr37AQMd52L-LZtz9Ld2QrLQ3YfcYhTw@mail.gmail.com>
	<CA+HiwqE+z2=wLv3a41h7JopcnUZAiFPeaiQyxZeGQ62QV3vsPQ@mail.gmail.com>
	<4f999141-97c8-c968-a726-0a1ec3e36e47@2ndquadrant.com>
	<ff6007b3-02c2-8296-2896-db99a51f57e2@2ndquadrant.com>
	<CA+HiwqGWXeBA2xagkz_YdxycmO38Vah_aviyJf_kC_kjCdL-Xg@mail.gmail.com>
	<CA+HiwqGkknVb+ccLVkgw1DoBYPzpuR43L+aT1eOT8dVEtiedtw@mail.gmail.com>

Hi,

On 03/04/2020 16:25, Amit Langote wrote:
> On Fri, Apr 3, 2020 at 6:34 PM Amit Langote <amitlangote09@gmail.com> wrote:
>> I am checking test coverage at the moment and should have the patches
>> ready by sometime later today.
> 
> Attached updated patches.
> 
> I confirmed using a coverage build that all the new code in
> logical/worker.c due to 0002 is now covered. For some reason, coverage
> report for pgoutput.c doesn't say the same thing for 0003's changes,
> although I doubt that result.  It seems strange to believe that *none*
> of the new code is tested.  I even checked by adding debugging elog()s
> next to the lines that the coverage report says aren't exercised,
> which tell me that that's not true. Perhaps my coverage build is
> somehow getting messed up, so it would be nice if someone with
> reliable coverage builds can confirm one way or the other. I will
> continue to check what's wrong.
> 

AFAIK gcov can't handle multiple instances of same process being started 
as it just overwrites the coverage files. So for TAP test it will report 
bogus info (as in some code that's executed will look as not executed). 
We'd probably have to do some kind of `GCOV_PREFIX` magic in the TAP 
framework and merge (gcov/lcov can do that AFAIK) the resulting files to 
get accurate coverage info. But that's beyond this patch IMHO.

-- 
Petr Jelinek
2ndQuadrant - PostgreSQL Solutions for the Enterprise
https://www.2ndQuadrant.com/





view thread (86+ messages)  latest in thread

Message-ID: <44ecae53-9861-71b7-1d43-4658acc52519@2ndquadrant.com>
Permalink:  ../44ecae53-9861-71b7-1d43-4658acc52519@2ndquadrant.com/
Also on:    postgresql.org/message-id/44ecae53-9861-71b7-1d43-4658acc52519@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: petr@2ndquadrant.com, amitlangote09@gmail.com, peter.eisentraut@2ndquadrant.com, rafia.pghackers@gmail.com
  Subject: Re: adding partitioned tables to publications
  In-Reply-To: <44ecae53-9861-71b7-1d43-4658acc52519@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox