From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Weird test mixup
Date: Fri, 15 Mar 2024 13:09:30 +0200
Message-ID: <44f5bf13-b46e-4b87-84de-2ac70fddbda0@iki.fi> (raw)
In-Reply-To: <2393552.1710458033@sss.pgh.pa.us>
References: <10fd6cdd-c5d9-46fe-9fa1-7e661191309e@iki.fi>
<2387221.1710454778@sss.pgh.pa.us>
<ZfOABU4ahF2QZQ6N@paquier.xyz>
<2393552.1710458033@sss.pgh.pa.us>
On 15/03/2024 01:13, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> Or we could just disable runningcheck because of the concurrency
>> requirement in this test. The test would still be able to run, just
>> less times.
>
> No, actually we *must* mark all these tests NO_INSTALLCHECK if we
> stick with the current definition of injection points. The point
> of installcheck mode is that the tests are supposed to be safe to
> run in a live installation. Side-effects occurring in other
> databases are completely not OK.
I committed a patch to do that, to put out the fire.
--
Heikki Linnakangas
Neon (https://neon.tech)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: hlinnaka@iki.fi, tgl@sss.pgh.pa.us, michael@paquier.xyz
Subject: Re: Weird test mixup
In-Reply-To: <44f5bf13-b46e-4b87-84de-2ac70fddbda0@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox