From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: Robert Haas <robertmhaas@gmail.com>
To: Aleksander Alekseev <a.alekseev@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: David Steele <david@pgmasters.net>
Subject: Re: [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables)
Date: Mon, 8 Aug 2016 11:47:32 +0300
Message-ID: <44fd10a5-2d16-86a4-5192-b85a6a16790c@postgrespro.ru> (raw)
In-Reply-To: <CA+Tgmob+AS4vPA-wp+KevL7q+qK4c7yZ5wjGvEv6EqPChE2oYQ@mail.gmail.com>
References: <20160729141552.4062e19b@fujitsu>
<39b0f423-a4df-3564-3b4a-b1de6f9eea80@2ndquadrant.com>
<CAFj8pRAv+vPxzTQMviCsYqQrfpYei5bTvX80zRUp1Q3xAbTWyg@mail.gmail.com>
<1184.1469890030@sss.pgh.pa.us>
<5cdc3fde-d6a5-f0d2-b930-485bdcaecde5@2ndquadrant.com>
<20160801124531.66cde374@fujitsu>
<26c3bc60-6613-e7ab-517a-53136f01fb6c@2ndquadrant.com>
<13191.1470072250@sss.pgh.pa.us>
<20160804151451.6fb87507@fujitsu>
<CA+Tgmob+AS4vPA-wp+KevL7q+qK4c7yZ5wjGvEv6EqPChE2oYQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
05.08.2016 19:41, Robert Haas:
>
> 2. This inserts additional code in a bunch of really low-level places
> like heap_hot_search_buffer, heap_update, heap_delete, etc. I think
> what you've basically done here is create a new, in-memory heap AM and
> then, because we don't have an API for adding new storage managers,
> you've bolted it onto the existing heapam layer. That's certainly a
> reasonable approach for creating a PoC, but I think we actually need a
> real API here. Otherwise, when the next person comes along and wants
> to add a third heap implementation, they've got to modify all of these
> same places again. I don't think this code is reasonably maintainable
> in this form.
As I can see, you recommend to clean up the API of storage
management code. I strongly agree that it's high time to do it.
So, I started the discussion about refactoring and improving API
of heapam and heap relations.
You can find it on commitfest:
https://commitfest.postgresql.org/10/700/
I'll be glad to see your thoughts on the thread.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.lubennikova@postgrespro.ru, robertmhaas@gmail.com, a.alekseev@postgrespro.ru, tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, pavel.stehule@gmail.com, david@pgmasters.net
Subject: Re: [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables)
In-Reply-To: <44fd10a5-2d16-86a4-5192-b85a6a16790c@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox