agora inbox for [email protected]  

help / color / mirror / Atom feed

From: Joshua D. Drake <[email protected]>
To: Tom Lane <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Stefan Kaltenbrunner <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: libedit broke in head
Date: Sat, 30 Sep 2006 19:17:54 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Tom Lane wrote:
> Alvaro Herrera <[email protected]> writes:
>> I think the switches are confusing ... when you are using libedit, you
>> certainly don't want readline as well, so it seems natural to disable
>> it.  I understand that what --without-readline really does is turn the
>> line-editing capability off in general rather than just readline, which
>> is confusing.

Just to verify. With removing the second switch, were good. It tested
and ran clean.

> 
> The documentation could be improved perhaps:
> 
> $ ./configure --help | grep -i edit    
>   --with-libedit-preferred  prefer BSD Libedit over GNU Readline
>   --without-readline      do not use GNU Readline / BSD Libedit line editing
> $
> 
> ISTM the second line would be clearer if it read
> 
>   --without-readline      do not use GNU Readline nor BSD Libedit for editing
> 
> Also, we probably ought to see if we can make the libedit-preferred line
> come out second.

I really don't get the libedit-preferred syntax? Why not just:

--with-libedit 	use BSD Libedit not GNU Readline
--with-readline use GNU Readline not BSD Libedit
--without-readline do not use GNU Readline nor BSD Libedit

Of course --without-readline is really a misnomer too. But
--without-edit doesn't sound right.

Sincerely,

Joshua D. Drake



> 
> 			regards, tom lane
> 


-- 

   === The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
   Providing the most comprehensive  PostgreSQL solutions since 1997
             http://www.commandprompt.com/

view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: libedit broke in head
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox