From: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Set log_lock_waits=on by default
Date: Thu, 28 Dec 2023 20:28:50 +0900
Message-ID: <4530a101c4d17174582b07875ead600d@oss.nttdata.com> (raw)
In-Reply-To: <cf3e8e3aadf380d7a6627fccdbc086b2c36d98df.camel@cybertec.at>
References: <b8b8502915e50f44deb111bc0b43a99e2733e117.camel@cybertec.at>
<CA+TgmobPaKeiXQ3q2Qb-ToLGPxy1kkOwi1AS16ZS0ryPKvPHTw@mail.gmail.com>
<cf3e8e3aadf380d7a6627fccdbc086b2c36d98df.camel@cybertec.at>
On 2023-12-22 20:00, Laurenz Albe wrote:
> My point is that in the vast majority of cases, long lock waits
> indicate a problem that you would like to know about, so the parameter
> should default to "on".
+1.
I always set log_lock_waits=on, so I agree with this.
>> Just a random idea but what if we separated log_lock_waits from
>> deadlock_timeout? Say, it becomes time-valued rather than
>> Boolean-valued, but it has to be >= deadlock_timeout? Because I'd
>> probably be more interested in hearing about a lock wait that was more
>> than say 10 seconds, but I don't necessarily want to wait 10 seconds
>> for the deadlock detector to trigger.
>
> That is an appealing thought, but as far as I know, "log_lock_waits"
> is implemented by the deadlock detector, which is why it is tied to
> "deadlock_timeout". So if we want that, we'd need a separate "live
> lock detector". I don't know if we want to go there.
Personally, I thought it was a good idea to separate log_lock_waits and
deadlock_timeout, but I have not checked how that is implemented.
--
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: Shinya11.Kato@oss.nttdata.com, laurenz.albe@cybertec.at, robertmhaas@gmail.com
Subject: Re: Set log_lock_waits=on by default
In-Reply-To: <4530a101c4d17174582b07875ead600d@oss.nttdata.com>
References: <b8b8502915e50f44deb111bc0b43a99e2733e117.camel@cybertec.at> <CA+TgmobPaKeiXQ3q2Qb-ToLGPxy1kkOwi1AS16ZS0ryPKvPHTw@mail.gmail.com> <cf3e8e3aadf380d7a6627fccdbc086b2c36d98df.camel@cybertec.at> <4530a101c4d17174582b07875ead600d@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox