From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Bryn Llewellyn <bryn@yugabyte.com>
Cc: pgsql-hackers list <pgsql-hackers@lists.postgresql.org>
Subject: Re: Have I found an interval arithmetic bug?
Date: Tue, 27 Jul 2021 16:01:54 -0400
Message-ID: <456756.1627416114@sss.pgh.pa.us> (raw)
In-Reply-To: <20210727193614.GE19774@momjian.us>
References: <BDAE4B56-3337-45A2-AC8A-30593849D6C0@yugabyte.com>
<20210402180549.GF9270@momjian.us>
<CALNJ-vRJUo62KNrQsiSsNAuPSBYpOXk8SPLh6r5jwHVzYai=HA@mail.gmail.com>
<20210402234943.GB29126@momjian.us>
<95D98B9E-CD54-4FAC-9574-D950E9741CAC@yugabyte.com>
<20210403010229.GE29126@momjian.us>
<20210727193614.GE19774@momjian.us>
Bruce Momjian <bruce@momjian.us> writes:
> I went ahead and modified the interval multiplication/division functions
> to use the same logic as fractional interval units:
Wait. A. Minute.
What I think we have consensus on is that interval_in is doing the
wrong thing in a particular corner case. I have heard nobody but
you suggesting that we should start undertaking behavioral changes
in other interval functions, and I don't believe that that's a good
road to start going down. These behaviors have stood for many years.
Moreover, since the whole thing is by definition operating with
inadequate information, it is inevitable that for every case you
make better there will be another one you make worse.
I'm really not on board with changing anything except interval_in,
and even there, we had better be certain that everything we change
is a case that is certainly being made better.
BTW, please do not post patches as gzipped attachments, unless
they're enormous. You're just adding another step making it
harder for people to look at them.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, bryn@yugabyte.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Have I found an interval arithmetic bug?
In-Reply-To: <456756.1627416114@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox