pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: John Naylor <johncnaylorls@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Gurjeet Singh <gurjeet@singh.im>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Change GUC hashtable to use simplehash?
Date: Fri, 08 Dec 2023 12:34:59 -0800
Message-ID: <456e1822959638b93af779582cc7c2cbc0a178ca.camel@j-davis.com> (raw)
In-Reply-To: <CANWCAZZYAZUH_3GYUtETmLOcd-5oD+kVC3cX889F7tzAQwtOsA@mail.gmail.com>
References: <c95e1821b6a69ec0c40eb0252e037b68a62cdae3.camel@j-davis.com>
	<20231117232712.mpnzsho7ydssg2oc@awork3.anarazel.de>
	<7fee9f31c2e82948fa56fe57d68eecb0cce36f10.camel@j-davis.com>
	<20231118001003.n2d7tvdgeckun2y6@awork3.anarazel.de>
	<27a7a289d5b8f42e1b1e79b1bcaeef3a40583bd2.camel@j-davis.com>
	<CANWCAZY7Cr-GdUhrCLoR4+JGLChTb0pQxq9ZPi1KTLs+_KDFqg@mail.gmail.com>
	<20231122205030.v6yllmmj6dgxpg5f@awork3.anarazel.de>
	<2330615.1700686581@sss.pgh.pa.us>
	<20231122212221.ahmlio2yfx7jla6z@awork3.anarazel.de>
	<2334462.1700688476@sss.pgh.pa.us>
	<20231122223432.lywt4yz2bn7tlp27@awork3.anarazel.de>
	<CANWCAZYDNjTh=8FxgZKmS8HEE=wcmLMoJx+Vvg3+xgAaGY=2oQ@mail.gmail.com>
	<CANWCAZb_17xdPP7v1_mXXg5TVbWkDzkP_WDgbCWpqUvz_VZ+OQ@mail.gmail.com>
	<a072ac527d7c0aee551784e97e1fffba5a457f49.camel@j-davis.com>
	<CANWCAZbMY6NSqg9j=_PH2ANTO95-7K8q=j7Si0d4CRGVJosPOw@mail.gmail.com>
	<d1b0cd83a75d397616cc4c2fd3106a0ec1a777f3.camel@j-davis.com>
	<CANWCAZZYAZUH_3GYUtETmLOcd-5oD+kVC3cX889F7tzAQwtOsA@mail.gmail.com>


I committed 867dd2dc87, which means my use case for a fast GUC hash
table (quickly setting proconfigs) is now solved.

Andres mentioned that it could still be useful to reduce overhead in a
few other places:

https://postgr.es/m/20231117220830.t6sb7di6h6am4ep5@awork3.anarazel.de

How should we evaluate GUC hash table performance optimizations? Just
microbenchmarks, or are there end-to-end tests where the costs are
showing up?

(As I said in another email, I think the hash function APIs justify
themselves regardless of improvements to the GUC hash table.)

On Wed, 2023-12-06 at 07:39 +0700, John Naylor wrote:
> > There's already a patch to use simplehash, and the API is a bit
> > cleaner, and there's a minor performance improvement. It seems
> > fairly
> > non-controversial -- should I just proceed with that patch?
> 
> I won't object if you want to commit that piece now, but I hesitate
> to
> call it a performance improvement on its own.
> 
> - The runtime measurements I saw reported were well within the noise
> level.
> - The memory usage starts out better, but with more entries is worse.

I suppose I'll wait until there's a reason to commit it, then.

Regards,
	Jeff Davis






view thread (103+ messages)  latest in thread

Message-ID: <456e1822959638b93af779582cc7c2cbc0a178ca.camel@j-davis.com>
Permalink:  ../456e1822959638b93af779582cc7c2cbc0a178ca.camel@j-davis.com/
Also on:    postgresql.org/message-id/456e1822959638b93af779582cc7c2cbc0a178ca.camel@j-davis.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: pgsql@j-davis.com, johncnaylorls@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, gurjeet@singh.im
  Subject: Re: Change GUC hashtable to use simplehash?
  In-Reply-To: <456e1822959638b93af779582cc7c2cbc0a178ca.camel@j-davis.com>
  References: <c95e1821b6a69ec0c40eb0252e037b68a62cdae3.camel@j-davis.com> <20231118001003.n2d7tvdgeckun2y6@awork3.anarazel.de> <27a7a289d5b8f42e1b1e79b1bcaeef3a40583bd2.camel@j-davis.com> <CANWCAZY7Cr-GdUhrCLoR4+JGLChTb0pQxq9ZPi1KTLs+_KDFqg@mail.gmail.com> <20231122205030.v6yllmmj6dgxpg5f@awork3.anarazel.de> <2330615.1700686581@sss.pgh.pa.us> <20231122212221.ahmlio2yfx7jla6z@awork3.anarazel.de> <2334462.1700688476@sss.pgh.pa.us> <20231122223432.lywt4yz2bn7tlp27@awork3.anarazel.de> <CANWCAZYDNjTh=8FxgZKmS8HEE=wcmLMoJx+Vvg3+xgAaGY=2oQ@mail.gmail.com> <CANWCAZb_17xdPP7v1_mXXg5TVbWkDzkP_WDgbCWpqUvz_VZ+OQ@mail.gmail.com> <a072ac527d7c0aee551784e97e1fffba5a457f49.camel@j-davis.com> <CANWCAZbMY6NSqg9j=_PH2ANTO95-7K8q=j7Si0d4CRGVJosPOw@mail.gmail.com> <d1b0cd83a75d397616cc4c2fd3106a0ec1a777f3.camel@j-davis.com> <CANWCAZZYAZUH_3GYUtETmLOcd-5oD+kVC3cX889F7tzAQwtOsA@mail.gmail.com> <456e1822959638b93af779582cc7c2cbc0a178ca.camel@j-davis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox