public inbox for [email protected]
help / color / mirror / Atom feedFrom: Euler Taveira <[email protected]>
To: Amit Kapila <[email protected]>
To: Peter Smith <[email protected]>
Cc: Ajin Cherian <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Greg Nancarrow <[email protected]>
Cc: vignesh C <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Rahila Syed <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Önder Kalacı <[email protected]>
Cc: japin <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: David Steele <[email protected]>
Cc: Craig Ringer <[email protected]>
Cc: Amit Langote <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: row filtering for logical replication
Date: Sun, 26 Dec 2021 12:54:07 -0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA4eK1KMmWhRUw-reLxnBw0s40mU8H-oYhapGz_WLD-mb3a7ig@mail.gmail.com>
References: <CAHut+PvSHjUsrrgVeE43hN8AZVPa8VqQ=GH1LYJFSubp2W_dhA@mail.gmail.com>
<CAHut+PtRdXzPpm3qv3cEYWWfVUkGT84EopEHxwt95eo_cG_3eQ@mail.gmail.com>
<OS0PR01MB571625D4A5CC1DAB4045B2BB94919@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<CAHut+Pu1AMDUwBNKeevLKOO2=M6ZBXpddi-s7fhqBpMxMWUQpA@mail.gmail.com>
<CAFPTHDZgxAbLA98HZkN-JNHoHXSBGtK4eAGQrXam5JQY6Zx7wg@mail.gmail.com>
<OS0PR01MB61132C0E4FFEE73D34AE9823FB999@OS0PR01MB6113.jpnprd01.prod.outlook.com>
<CAJcOf-d0=Pnv8qpBaN5WM5wtmhT3EJ64crWtfPBtiwtK8iUEwg@mail.gmail.com>
<CAHut+Pv-D4rQseRO_OzfEz2dQsTKEnKjBCET9Z-iJppyT1XNMQ@mail.gmail.com>
<CALDaNm2bq-Zab3i5pvuA3UTxHvo3BqPwmgXbyznpw5vz4=fxpA@mail.gmail.com>
<OS0PR01MB57162EB465A0E6BCFDF9B3F394609@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<CAA4eK1KZ+N=vfgqeUuZfRLRC+WyNBFvU9Ei7kF-7OPXnTX2WrA@mail.gmail.com>
<OS0PR01MB5716F2C3904CB807050010A394619@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<CAA4eK1KVUs2s3PTcTTRj3qdmUzEDG7PQ5Xq_b1J7zMsi2OvE5w@mail.gmail.com>
<OS0PR01MB57168FD9932E3F42406EB13B94629@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<CAJcOf-dz0srExG0NPPgXh5X8eL2uxk7C=cZoGTbf8cNqoRUY6w@mail.gmail.com>
<CAA4eK1+8UqT5b3Ha42Wt07668yxs9KkKvV5r==vT9KfRUGCs-g@mail.gmail.com>
<[email protected]>
<CAA4eK1+hVXfOSScbf5LUB=5is=wYaC6NBhLxuvetbWQnZRnsVQ@mail.gmail.com>
<CAHut+PtJnnM8MYQDf7xCyFAp13U_0Ya2dv-UQeFD=ghixFLZiw@mail.gmail.com>
<[email protected]>
<CAA4eK1+C2Z8bmGT_7xo4T+fZqqTr1i56Hidv9krmaEDUACwGjA@mail.gmail.com>
<[email protected]>
<CAA4eK1K-+GhHqG+8yJb-neWxR_B+yeXTj7cCg9OqxTmPK3seRA@mail.gmail.com>
<CAHut+PugCTDwoS6Ysaocj+AjqSUuxB5qL6F=7_E2v59E9MZm7A@mail.gmail.com>
<CAFPTHDYB4nbxCMAFQGowJtDf7E6uBc==_HupBKy7MaMhM+9QQA@mail.gmail.com>
<CAHut+Ptoxjo6hpDFTya6WYH-zdspKQ5j+wZHBRc6EZkAkq7Nfw@mail.gmail.com>
<CAHut+Ptjsj_OVMWEdYp2Wq19=H5D4Vgta43FbFVDYr2LuS_djg@mail.gmail.com>
<CAA4eK1KbzN-WYXNpYdHheaB+eEQN+Rq4=1BQy=6TW2qLEw139g@mail.gmail.com>
<OS0PR01MB5716BBB443019ED97FC48A0C947B9@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<[email protected]>
<CAFPTHDbfpPNh3GLGjySS=AuRfbQPQFNvfiyG1GDQW2kz1yT7Og@mail.gmail.com>
<CAA4eK1JgdhDnAvFV-eEWcqMmXYwo9kmCE1wA17xWGE621e8WDg@mail.gmail.com>
<CAFPTHDaqWcefAoVsurJDQ6bKK9_U2wNCWEuOrkt70ZKspfWhGw@mail.gmail.com>
<CAHut+Pv4os_ZtB4uJE6hi_Kp4px6e3WtPTX-7eTK9YJicqq1Cw@mail.gmail.com>
<CAHut+PsUe3+crzQF_Ljivp5UgxkuEMBM76K=M+8fp41rXb-46Q@mail.gmail.com>
<CAHut+PspqgAY1SANix1UKUEBYsW2DZjstAkmLXP=K7H2-1pgZg@mail.gmail.com>
<CAA4eK1KMmWhRUw-reLxnBw0s40mU8H-oYhapGz_WLD-mb3a7ig@mail.gmail.com>
On Sat, Dec 25, 2021, at 1:20 AM, Amit Kapila wrote:
> On Fri, Dec 24, 2021 at 11:04 AM Peter Smith <[email protected]> wrote:
> >
> > So, IMO the PG docs wording for this part should be relaxed a bit.
> >
> > e.g.
> > BEFORE:
> > + A nullable column in the <literal>WHERE</literal> clause could cause the
> > + expression to evaluate to false; avoid using columns without not-null
> > + constraints in the <literal>WHERE</literal> clause.
> > AFTER:
> > + A nullable column in the <literal>WHERE</literal> clause could cause the
> > + expression to evaluate to false. To avoid unexpected results, any possible
> > + null values should be accounted for.
> >
>
> Your suggested wording sounds reasonable to me. Euler, others, any thoughts?
+1.
--
Euler Taveira
EDB https://www.enterprisedb.com/
view thread (489+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: row filtering for logical replication
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox