public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Ayush Tiwari <[email protected]>
To: PostgreSQL Hackers <[email protected]>
To: Ashutosh Bapat <[email protected]>
Subject: Re: [PATCH] Clean up property graph error messages
Date: Thu, 7 May 2026 10:45:13 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAJTYsWXFy1j_T82+M_S9kFxU414tQYnZQD-b82=oL_LbG_5fPQ@mail.gmail.com>
References: <CAJTYsWXFy1j_T82+M_S9kFxU414tQYnZQD-b82=oL_LbG_5fPQ@mail.gmail.com>

On 04.05.26 21:57, Ayush Tiwari wrote:
> While looking at the SQL/PGQ property graph error paths, I noticed a
> few small cleanups in propgraphcmds.c.
> 
> The attached patch fixes a user-visible error message from "mismatching
> properties names" to "mismatching property names",

I have fixed that.

> and moves a
> ReleaseSysCache() call before an ERROR ereport in
> check_element_properties().
> 
> The existing code should be cleaned up by
> the resource owner on the ERROR path, but the explicit ReleaseSysCache()
> placed after ereport(ERROR) was unreachable.

I think that's fine.  I don't think the change makes this better.

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Clean up property graph error messages
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox