pg.ddx.io pgsql-hackers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
A typo in error message 3+ messages / 3 participants [nested] [flat]
Commits from this thread: 2018-01-31 22757960bb a9fd6c3216 Fix typo: colums -> columns.
* A typo in error message @ 2018-01-31 05:47 Alexander Lakhin <exclusion@gmail.com> 2018-01-31 05:53 ` Re: A typo in error message Michael Paquier <michael.paquier@gmail.com> 0 siblings, 1 reply; 3+ messages in thread From: Alexander Lakhin @ 2018-01-31 05:47 UTC (permalink / raw) To: pgsql-hackers Hello, Please consider committing the attached patch to fix a typo in error message. Best regards, -- Alexander Lakhin Postgres Professional: http://www.postgrespro.com The Russian Postgres Company Attachments:^ permalink raw reply [nested|flat] 3+ messages in threadcolums.patch (text/x-patch, 1.3K) download
diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c index e0d96d7..4894812 100644 --- a/src/backend/parser/parse_utilcmd.c +++ b/src/backend/parser/parse_utilcmd.c @@ -668,7 +668,7 @@ transformColumnDefinition(CreateStmtContext *cxt, ColumnDef *column) if (cxt->ofType) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), - errmsg("identity colums are not supported on typed tables"))); + errmsg("identity columns are not supported on typed tables"))); if (cxt->partbound) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), diff --git a/src/test/regress/expected/identity.out b/src/test/regress/expected/identity.out index 87ef0d3..627389b 100644 --- a/src/test/regress/expected/identity.out +++ b/src/test/regress/expected/identity.out @@ -349,7 +349,7 @@ DROP USER regress_user1; -- typed tables (currently not supported) CREATE TYPE itest_type AS (f1 integer, f2 text, f3 bigint); CREATE TABLE itest12 OF itest_type (f1 WITH OPTIONS GENERATED ALWAYS AS IDENTITY); -- error -ERROR: identity colums are not supported on typed tables +ERROR: identity columns are not supported on typed tables DROP TYPE itest_type CASCADE; -- table partitions (currently not supported) CREATE TABLE itest_parent (f1 date NOT NULL, f2 text, f3 bigint) PARTITION BY RANGE (f1);
* Re: A typo in error message 2018-01-31 05:47 A typo in error message Alexander Lakhin <exclusion@gmail.com> @ 2018-01-31 05:53 ` Michael Paquier <michael.paquier@gmail.com> 2018-01-31 21:47 ` Re: A typo in error message Robert Haas <robertmhaas@gmail.com> 0 siblings, 1 reply; 3+ messages in thread From: Michael Paquier @ 2018-01-31 05:53 UTC (permalink / raw) To: Alexander Lakhin <exclusion@gmail.com>; +Cc: pgsql-hackers On Wed, Jan 31, 2018 at 08:47:57AM +0300, Alexander Lakhin wrote: > Please consider committing the attached patch to fix a typo in error > message. Yeah.. > if (cxt->ofType) > ereport(ERROR, > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > - errmsg("identity colums are not supported on typed tables"))); > + errmsg("identity columns are not supported on typed tables"))); > if (cxt->partbound) > ereport(ERROR, > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), The indentation for this ereport() is weird as well here. -- Michael Attachments: signature.asc (application/pgp-signature, 832B) download ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: A typo in error message 2018-01-31 05:47 A typo in error message Alexander Lakhin <exclusion@gmail.com> 2018-01-31 05:53 ` Re: A typo in error message Michael Paquier <michael.paquier@gmail.com> @ 2018-01-31 21:47 ` Robert Haas <robertmhaas@gmail.com> 0 siblings, 0 replies; 3+ messages in thread From: Robert Haas @ 2018-01-31 21:47 UTC (permalink / raw) To: Michael Paquier <michael.paquier@gmail.com>; +Cc: Alexander Lakhin <exclusion@gmail.com>; pgsql-hackers On Wed, Jan 31, 2018 at 12:53 AM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Wed, Jan 31, 2018 at 08:47:57AM +0300, Alexander Lakhin wrote: >> Please consider committing the attached patch to fix a typo in error >> message. > > Yeah.. Committed. >> if (cxt->ofType) >> ereport(ERROR, >> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), >> - errmsg("identity colums are not supported on typed tables"))); >> + errmsg("identity columns are not supported on typed tables"))); >> if (cxt->partbound) >> ereport(ERROR, >> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > > The indentation for this ereport() is weird as well here. Hit it with pgindent to fix this, too. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2018-01-31 21:47 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2018-01-31 05:47 A typo in error message Alexander Lakhin <exclusion@gmail.com> 2018-01-31 05:53 ` Michael Paquier <michael.paquier@gmail.com> 2018-01-31 21:47 ` Robert Haas <robertmhaas@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox