From: Richard Huxton <dev@archonet.com>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Zeugswetter Andreas ADI SD <ZeugswetterA@spardat.at>
Cc: Koichi Suzuki <suzuki.koichi@oss.ntt.co.jp>
Cc: josh@agliodbs.com
Cc: pgsql-hackers@postgresql.org
Cc: pgsql-patches@postgresql.org
Subject: Re: [PATCHES] Full page writes improvement, code update
Date: Fri, 30 Mar 2007 11:27:10 +0100
Message-ID: <460CE5FE.5050906@archonet.com> (raw)
In-Reply-To: <1175249717.4386.716.camel@silverbirch.site>
References: <460886E8.6040907@oss.ntt.co.jp>
<4609CAC3.7060008@oss.ntt.co.jp>
<1175072848.4386.323.camel@silverbirch.site>
<200703291145.28574.josh@agliodbs.com>
<1175200117.4386.616.camel@silverbirch.site>
<460C611E.6090800@oss.ntt.co.jp>
<E1539E0ED7043848906A8FF995BDA57901E7B246@m0143.s-mxs.net>
<1175249717.4386.716.camel@silverbirch.site>
Simon Riggs wrote:
> On Fri, 2007-03-30 at 10:22 +0200, Zeugswetter Andreas ADI SD wrote:
>>> Without a switch, because both full page writes and
>>> corresponding logical log is included in WAL, this will
>>> increase WAL size slightly
>>> (maybe about five percent or so). If everybody is happy
>>> with this, we
>>> don't need a switch.
>> Sorry, I still don't understand that. What is the "corresponding logical
>> log" ?
>> It seems to me, that a full page WAL record has enough info to produce a
>>
>> dummy LSN WAL entry. So insead of just cutting the full page wal record
>> you
>> could replace it with a LSN WAL entry when archiving the log.
>>
>> Then all that is needed is the one flag, no extra space ?
>
> The full page write is required for crash recovery, but that isn't
> required during archive recovery because the base backup provides the
> safe base.
Is that always true? Could the backup not pick up a partially-written
page? Assuming it's being written to as the backup is in progress. (We
are talking about when disk blocks are smaller than PG blocks here, so
can't guarantee an atomic write for a PG block?)
--
Richard Huxton
Archonet Ltd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dev@archonet.com, simon@2ndquadrant.com, ZeugswetterA@spardat.at, suzuki.koichi@oss.ntt.co.jp, josh@agliodbs.com, pgsql-patches@postgresql.org
Subject: Re: [PATCHES] Full page writes improvement, code update
In-Reply-To: <460CE5FE.5050906@archonet.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox