From: Alexander Lakhin <exclusion@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: Tender Wang <tndrwang@gmail.com>
Cc: Junwang Zhao <zhjwpku@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Guillaume Lelarge <guillaume@lelarge.info>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails
Date: Thu, 24 Oct 2024 17:00:00 +0300
Message-ID: <461e9c26-2076-8224-e119-84998b6a784e@gmail.com> (raw)
In-Reply-To: <202410221432.3qtqbk2q6o7q@alvherre.pgsql>
References: <202410221432.3qtqbk2q6o7q@alvherre.pgsql>
Hello Alvaro,
22.10.2024 17:32, Alvaro Herrera wrote:
> Yeah. I pushed these patches finally, thanks!
Please look at a new anomaly introduced with 53af9491a. When running the
following script:
CREATE TABLE t (a int, b int, PRIMARY KEY (a, b));
CREATE TABLE pt (a int, b int, FOREIGN KEY (a, b) REFERENCES t(a, b))
PARTITION BY LIST (a);
CREATE TABLE tp1 (x int, a int, b int);
ALTER TABLE tp1 DROP COLUMN x;
ALTER TABLE pt ATTACH PARTITION tp1 FOR VALUES IN (1);
ALTER TABLE pt DETACH PARTITION tp1;
I get a memory access error detected by Valgrind:
2024-10-24 12:05:04.645 UTC [1079077] LOG: statement: ALTER TABLE pt DETACH PARTITION tp1;
==00:00:00:07.887 1079077== Invalid read of size 2
==00:00:00:07.887 1079077== at 0x4A61DD: DetachPartitionFinalize (tablecmds.c:19545)
==00:00:00:07.887 1079077== by 0x4A5C11: ATExecDetachPartition (tablecmds.c:19386)
==00:00:00:07.887 1079077== by 0x48561E: ATExecCmd (tablecmds.c:5540)
==00:00:00:07.887 1079077== by 0x4845DE: ATRewriteCatalogs (tablecmds.c:5203)
==00:00:00:07.887 1079077== by 0x4838EC: ATController (tablecmds.c:4758)
==00:00:00:07.887 1079077== by 0x4834F1: AlterTable (tablecmds.c:4404)
==00:00:00:07.887 1079077== by 0x7D6D52: ProcessUtilitySlow (utility.c:1318)
==00:00:00:07.887 1079077== by 0x7D65F7: standard_ProcessUtility (utility.c:1067)
==00:00:00:07.887 1079077== by 0x7D54F7: ProcessUtility (utility.c:523)
==00:00:00:07.887 1079077== by 0x7D3D70: PortalRunUtility (pquery.c:1158)
==00:00:00:07.887 1079077== by 0x7D3FE7: PortalRunMulti (pquery.c:1316)
==00:00:00:07.887 1079077== by 0x7D3431: PortalRun (pquery.c:791)
Reproduced on REL_15_STABLE .. master.
Best regards,
Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: exclusion@gmail.com, alvherre@alvh.no-ip.org, jgdr@dalibo.com, tndrwang@gmail.com, zhjwpku@gmail.com, guillaume@lelarge.info, michael@paquier.xyz
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails
In-Reply-To: <461e9c26-2076-8224-e119-84998b6a784e@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox