pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Koichi Suzuki <suzuki.koichi@oss.ntt.co.jp>
To: Zeugswetter Andreas ADI SD <ZeugswetterA@spardat.at>
Cc: Hannu Krosing <hannu@skype.net>
Cc: Joshua D. Drake <jd@commandprompt.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: josh@agliodbs.com
Cc: pgsql-hackers@postgresql.org
Cc: pgsql-patches@postgresql.org
Subject: Re: [HACKERS] Full page writes improvement, code update
Date: Thu, 26 Apr 2007 10:19:45 +0900
Message-ID: <462FFE31.6050707@oss.ntt.co.jp> (raw)
In-Reply-To: <E1539E0ED7043848906A8FF995BDA57901F3FF7A@m0143.s-mxs.net>
References: <460886E8.6040907@oss.ntt.co.jp>
	<4609CAC3.7060008@oss.ntt.co.jp>
	<1175072848.4386.323.camel@silverbirch.site>
	<200703291145.28574.josh@agliodbs.com>
	<1175200117.4386.616.camel@silverbirch.site>
	<460C611E.6090800@oss.ntt.co.jp>
	<27693.1176226131@sss.pgh.pa.us>
	<461C3557.6040201@oss.ntt.co.jp>
	<461C3732.20006@commandprompt.com>
	<1176269612.3962.11.camel@localhost.localdomain>
	<461D9090.60808@oss.ntt.co.jp>
	<E1539E0ED7043848906A8FF995BDA57901E7BD64@m0143.s-mxs.net>
	<461ECA4E.9010101@oss.ntt.co.jp>
	<E1539E0ED7043848906A8FF995BDA57901E7BEBE@m0143.s-mxs.net>
	<462856EF.1030005@oss.ntt.co.jp>
	<E1539E0ED7043848906A8FF995BDA57901F3FC4B@m0143.s-mxs.net>
	<462BFB11.7000409@oss.ntt.co.jp>
	<E1539E0ED7043848906A8FF995BDA57901F3FF7A@m0143.s-mxs.net>

Hi,

Zeugswetter Andreas ADI SD wrote:
>> I don't insist the name and the default of the GUC parameter. 
>>  I'm afraid wal_fullpage_optimization = on (default) makes 
>> some confusion because the default behavior becomes a bit 
>> different on WAL itself.
> 
> Seems my wal_fullpage_optimization is not a good name if it caused
> misinterpretation already :-(
> 
>>>> Amount of WAL after 60min. run of DBT-2 benchmark 
>>>> wal_add_optimization_info = off (default) 3.13GB
>>> how about wal_fullpage_optimization = on (default)
> 
> The meaning of wal_fullpage_optimization = on (default)
> would be the same as your wal_add_optimization_info = off (default).
> (Reversed name, reversed meaning of the boolean value)
> 
> It would be there to *turn off* the (default) WAL full_page
> optimization.
> For your pg_compresslog it would need to be set to off. 
> "add_optimization_info" sounded like added info about/for some
> optimization
> which it is not. We turn off an optimization with the flag for the
> benefit
> of an easier pg_compresslog implementation.

For pg_compresslog to remove full page writes, we need 
wal_add_optimization_info=on.

> 
> As already said I would decouple this setting from the part that sets
> the "removeable full page" flag in WAL, and making the recovery able to
> skip dummy records. This I would do unconditionally.
> 
> Andreas
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
> 
>                http://www.postgresql.org/docs/faq
> 


-- 
-------------
Koichi Suzuki



view thread (64+ messages)  latest in thread

Message-ID: <462FFE31.6050707@oss.ntt.co.jp>
Permalink:  ../462FFE31.6050707@oss.ntt.co.jp/
Also on:    postgresql.org/message-id/462FFE31.6050707@oss.ntt.co.jp

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: suzuki.koichi@oss.ntt.co.jp, ZeugswetterA@spardat.at, hannu@skype.net, jd@commandprompt.com, tgl@sss.pgh.pa.us, simon@2ndquadrant.com, josh@agliodbs.com, pgsql-patches@postgresql.org
  Subject: Re: [HACKERS] Full page writes improvement, code update
  In-Reply-To: <462FFE31.6050707@oss.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox