From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: pg_upgrade fails to detect unsupported arrays and ranges
Date: Sun, 10 Nov 2019 16:05:43 -0500
Message-ID: <4650.1573419943@sss.pgh.pa.us> (raw)
In-Reply-To: <124042D9-F307-402A-80ED-395C154858BA@yesql.se>
References: <31473.1573412838@sss.pgh.pa.us>
<124042D9-F307-402A-80ED-395C154858BA@yesql.se>
Daniel Gustafsson <daniel@yesql.se> writes:
> On 10 Nov 2019, at 20:07, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Although this is a really straightforward patch and I've tested it
>> against appropriate old versions (9.1 and 9.2), I'm very hesitant
>> to shove it in so soon before a release wrap. Should I do that, or
>> let it wait till after the wrap?
> Having read the patch I agree that it's trivial enough that I wouldn't be
> worried to let it slip through. However, given that we've lacked the check for
> a few releases, is it worth rushing with the potential for a last-minute
> "oh-shit"?
Probably not, really --- the main argument for that is just that it'd fit
well with the fixes Tomas already made.
>> + /* arrays over any type selected so far */
>> + " SELECT t.oid FROM pg_catalog.pg_type t, x WHERE typelem = x.oid AND typtype = 'b' "
> No need to check typlen?
Yeah, that's intentional. A fixed-length array type over a problematic
type would be just as much of a problem as a varlena array type.
The case shouldn't apply to any of the existing problematic types,
but I was striving for generality.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, pgsql-hackers@lists.postgresql.org, tomas.vondra@2ndquadrant.com
Subject: Re: pg_upgrade fails to detect unsupported arrays and ranges
In-Reply-To: <4650.1573419943@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox