agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Adding CI to our tree
Date: Mon, 17 Jan 2022 14:18:09 -0500
Message-ID: <47040.1642447089@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmoap6WXzta=zw97SF73hCfzEWVMtfDFB01svYXMtTzKVVA@mail.gmail.com>
References: <20211001222752.wrz7erzh4cajvgp6@alap3.anarazel.de>
<20211231014652.kgrdk2wytiallix3@alap3.anarazel.de>
<20220109191649.GL14051@telsasoft.com>
<20220109195744.mjoue2pr6xtnsquw@alap3.anarazel.de>
<20220110220748.GS14051@telsasoft.com>
<20220113185527.kgzmxutkydkyktuq@alap3.anarazel.de>
<63f3be31-d7c4-0ff4-e5f4-7368863da1bc@dunslane.net>
<20220114233411.2byuid4umwjqbhug@alap3.anarazel.de>
<20220114235457.GQ14051@telsasoft.com>
<87a81b91-87bf-c0bc-7e4f-06dffadcf737@dunslane.net>
<20220117181946.bmvubqpzqxlvmgeh@alap3.anarazel.de>
<CA+Tgmoap6WXzta=zw97SF73hCfzEWVMtfDFB01svYXMtTzKVVA@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> I have a lot of sympathy with Andrew here, actually. If you just do
> 'make check-world' and assume that will cover everything, you get one
> giant output file. That is not great at all.
Yeah. I agree with Andrew that we want output that is more modular,
not less so. But we do need to find a way to have less knowledge
hard-wired in the buildfarm client script.
> But having said that, I also agree that it sucks to have to keep
> updating the BF client every time we want to do any kind of
> test-related changes in the main source tree. One way around that
> would be to put a file in the main source tree that the build farm
> client can read to know what to do. Another would be to have the BF
> client download the latest list of steps from somewhere instead of
> having it in the source code, so that it can be updated without
> everyone needing to update their machine.
The obvious place for "somewhere" is "the main source tree", so I
doubt your second suggestion is better than your first. But your
first does seem like a plausible way to proceed.
Another way to think of it, maybe, is to migrate chunks of the
buildfarm client script itself into the source tree. I'd rather
that developers not need to become experts on the buildfarm client
to make adjustments to the test process --- but I suspect that
a simple script like "run make check in these directories" is
not going to be flexible enough for everything.
regards, tom lane
view thread (142+ messages) latest in thread
Message-ID: <47040.1642447089@sss.pgh.pa.us>
Permalink: ../47040.1642447089@sss.pgh.pa.us/
Also on: postgresql.org/message-id/47040.1642447089@sss.pgh.pa.us
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de, andrew@dunslane.net, pryzby@telsasoft.com, thomas.munro@gmail.com, melanieplageman@gmail.com, peter.eisentraut@enterprisedb.com, daniel@yesql.se
Subject: Re: Adding CI to our tree
In-Reply-To: <47040.1642447089@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox