pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: Anton A. Melnikov <a.melnikov@postgrespro.ru>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?
Date: Wed, 24 Apr 2024 11:02:14 +0200
Message-ID: <474746ef-fa9f-400e-902e-3bb018320ca0@eisentraut.org> (raw)
In-Reply-To: <0841ec77-47e5-452a-adb4-c6fa55d605fc@postgrespro.ru>
References: <0841ec77-47e5-452a-adb4-c6fa55d605fc@postgrespro.ru>

On 19.04.24 05:50, Anton A. Melnikov wrote:
> There is a macro XLOG_CONTROL_FILE for control file name
> defined in access/xlog_internal.h
> And there are some places in code where this macro is used
> like here
> https://github.com/postgres/postgres/blob/84db9a0eb10dd1dbee6db509c0e427fa237177dc/src/bin/pg_resetw...
> or here
> https://github.com/postgres/postgres/blob/84db9a0eb10dd1dbee6db509c0e427fa237177dc/src/common/contro...
> 
> But there are some other places where the control file
> name is used as text string directly.
> 
> May be better use this macro everywhere in C code?

I don't know.  I don't find XLOG_CONTROL_FILE to be a very intuitive 
proxy for "pg_control".






view thread (26+ messages)  latest in thread

Message-ID: <474746ef-fa9f-400e-902e-3bb018320ca0@eisentraut.org>
Permalink:  ../474746ef-fa9f-400e-902e-3bb018320ca0@eisentraut.org/
Also on:    postgresql.org/message-id/474746ef-fa9f-400e-902e-3bb018320ca0@eisentraut.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter@eisentraut.org, a.melnikov@postgrespro.ru
  Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?
  In-Reply-To: <474746ef-fa9f-400e-902e-3bb018320ca0@eisentraut.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox