From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: bloated heapam.h
Date: Thu, 15 May 2008 17:48:58 +0200
Message-ID: <482C5B6A.5080804@sun.com> (raw)
In-Reply-To: <20080513154200.GH6966@alvh.no-ip.org>
References: <20080512000642.GB5746@alvh.no-ip.org>
<20080512002153.GC5746@alvh.no-ip.org>
<20080512002853.GD5746@alvh.no-ip.org>
<48283673.2080304@sun.com>
<20080512161350.GM5655@alvh.no-ip.org>
<48289595.7050708@sun.com>
<20080512192656.GA19344@alvh.no-ip.org>
<48289FFB.8010500@sun.com>
<20080512200253.GB19344@alvh.no-ip.org>
<4828B7AF.4030002@sun.com>
<20080513154200.GH6966@alvh.no-ip.org>
Alvaro Herrera wrote:
> Zdenek Kotala wrote:
>> Alvaro Herrera napsal(a):
>>
>>>> I try to play with lint now if it gets better results.
>>> Ok, good.
>> Hmm, It generates a lot of unnecessary includes in *.c files. I have
>> checked only couple of them and it seems that they are really
>> unnecessary. A attach output. Unfortunately, it does not detect missing
>> heapam.h from bufpage.h. However, I have not tested all magic switches
>> yet :-). There are also several reports about system headers file, but
>> it could be platform specific warning.
>
> Interesting. It seems that Bruce's script could be replaced by lint.
> Please share the switches you used.
>
I used following switches which only shows unused included file. I run command
in backend directory.
lint -I ../include -errtags -errhdr=%all -Ncheck=%none -Nlevel=1 -erroff=%all
-erroff=no%E_INCL_NUSD -c `find . -name "*.c"` > include.out
Good to mention that I use lint from Sun Studio 12.
Zdenek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: Zdenek.Kotala@Sun.COM, alvherre@commandprompt.com, tgl@sss.pgh.pa.us
Subject: Re: bloated heapam.h
In-Reply-To: <482C5B6A.5080804@sun.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox