From: Andrew Dunstan <andrew@dunslane.net>
To: Magnus Hagander <magnus@hagander.net>
Cc: Dave Page <dpage@pgadmin.org>
Cc: Josh Berkus <josh@agliodbs.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: It's June 1; do you know where your release is?
Date: Thu, 04 Jun 2009 08:44:43 -0400
Message-ID: <4A27C1BB.7080909@dunslane.net> (raw)
In-Reply-To: <4A27AA1D.6000800@hagander.net>
References: <19107.1243873940@sss.pgh.pa.us>
<603c8f070906012050p6ccd62d3v13d3e0f887fe7c90@mail.gmail.com>
<alpine.BSO.2.00.0906020108410.15690@leary.csoft.net>
<15765.1243965376@sss.pgh.pa.us>
<4A25C32F.30203@agliodbs.com>
<4A25C9A9.5010303@dunslane.net>
<4A25D91B.5080401@dunslane.net>
<4A26FF38.8090308@dunslane.net>
<937d27e10906031610g341525e5j9414d8af3d8f293c@mail.gmail.com>
<4A270A06.1010507@dunslane.net>
<937d27e10906040249u73ac21dds6057300011d38a2d@mail.gmail.com>
<4A27AA1D.6000800@hagander.net>
Magnus Hagander wrote:
> Dave Page wrote:
>
>> On Thu, Jun 4, 2009 at 12:40 AM, Andrew Dunstan <andrew@dunslane.net> wrote:
>>
>>> Of course, that leaves the issue of the library name to be fixed, but
>>> sufficient unto the day ...
>>>
>> Yeah - I chatted briefly with Magnus about that a while back. I added
>> a quick hack to Mkvcbuild.pm to allow it to use either 5.10 or 5.8,
>> but didn't even think about the msys build.
>>
>>
>
> Yeah, this is something we need to look at for 8.5. I think it's too
> late in the cycle to start messing with it for 8.4.
>
I don't see why. Perl 5.10 is out there and people will want to use it.
I have a simple fix for this in GNUMakefile (see below) , and putting
something similar in the MSVC build stuff will be simple too. If we
don't want to support Perl 5.10 why was the item on the open issues list
at all (and why did I just spend hours finding a solution to the hard part)?
I have cleaned up the patch from yesterday slightly, too. I'm wondering
how far back we should backpatch all this. This API was actually
documented in Perl (just) before 7.4 was released, so in theory the API
adjustment should go all the way back. However, in practice it hasn't
been a problem until now, and we aren't supporting Windows releases
before 8.2, so I think 8.2 is probably the right spot.
cheers
andrew
Index: GNUmakefile
===================================================================
RCS file: /cvsroot/pgsql/src/pl/plperl/GNUmakefile,v
retrieving revision 1.36
diff -u -r1.36 GNUmakefile
--- GNUmakefile 2 Oct 2008 08:11:11 -0000 1.36
+++ GNUmakefile 4 Jun 2009 12:28:31 -0000
@@ -19,7 +19,8 @@
ifeq ($(PORTNAME), win32)
perl_archlibexp := $(subst \,/,$(perl_archlibexp))
perl_privlibexp := $(subst \,/,$(perl_privlibexp))
-perl_embed_ldflags = -L$(perl_archlibexp)/CORE -lperl58
+perl_lib := $(basename $(notdir $(wildcard
$(perl_archlibexp)/CORE/perl*.lib)))
+perl_embed_ldflags = -L$(perl_archlibexp)/CORE -l$(perl_lib)
override CPPFLAGS += -DPLPERL_HAVE_UID_GID
# Perl on win32 contains /* within comment all over the header file,
# so disable this warning.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@dunslane.net, magnus@hagander.net, dpage@pgadmin.org, josh@agliodbs.com
Subject: Re: It's June 1; do you know where your release is?
In-Reply-To: <4A27C1BB.7080909@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox