pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedRe: display previous query string of idle-in-transaction
4+ messages / 4 participants
[nested] [flat]
* Re: display previous query string of idle-in-transaction
@ 2009-06-03 14:24 Greg Stark <stark@enterprisedb.com>
0 siblings, 1 reply; 4+ messages in thread
From: Greg Stark @ 2009-06-03 14:24 UTC (permalink / raw)
To: Asko Oja <ascoja@gmail.com>; +Cc: decibel <decibel@decibel.org>; Simon Riggs <simon@2ndquadrant.com>; Tatsuhito Kasahara <kasahara.tatsuhito@oss.ntt.co.jp>; pgsql-hackers
Should this patch be on the commitfest page for 8.5? Or is there a
consensus already that it's a bad idea?
Personally I actually think this makes a lot of sense to do.
--
greg
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: display previous query string of idle-in-transaction
@ 2009-06-03 14:33 Kevin Grittner <Kevin.Grittner@wicourts.gov>
parent: Greg Stark <stark@enterprisedb.com>
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Grittner @ 2009-06-03 14:33 UTC (permalink / raw)
To: Greg Stark <stark@enterprisedb.com>; Asko Oja <ascoja@gmail.com>; +Cc: Simon Riggs <simon@2ndquadrant.com>; decibel <decibel@decibel.org>; Tatsuhito Kasahara <kasahara.tatsuhito@oss.ntt.co.jp>; pgsql-hackers
Greg Stark <stark@enterprisedb.com> wrote:
> Should this patch be on the commitfest page for 8.5? Or is there a
> consensus already that it's a bad idea?
>
> Personally I actually think this makes a lot of sense to do.
+1
It at least gives one a reasonable chance to get a useful clue....
-Kevin
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: display previous query string of idle-in-transaction
@ 2009-06-05 01:54 Tatsuhito Kasahara <kasahara.tatsuhito@oss.ntt.co.jp>
parent: Kevin Grittner <Kevin.Grittner@wicourts.gov>
0 siblings, 1 reply; 4+ messages in thread
From: Tatsuhito Kasahara @ 2009-06-05 01:54 UTC (permalink / raw)
To: Kevin Grittner <Kevin.Grittner@wicourts.gov>; +Cc: Greg Stark <stark@enterprisedb.com>; Asko Oja <ascoja@gmail.com>; Simon Riggs <simon@2ndquadrant.com>; decibel <decibel@decibel.org>; pgsql-hackers@postgresql.org, "kasahara(OSSC)" <kasahara.tatsuhito@oss.ntt.co.jp>
Kevin Grittner wrote:
> Greg Stark <stark@enterprisedb.com> wrote:
>> Should this patch be on the commitfest page for 8.5? Or is there a
>> consensus already that it's a bad idea?
>>
>> Personally I actually think this makes a lot of sense to do.
>
> +1
>
> It at least gives one a reasonable chance to get a useful clue....
+1
# And I'm going to register this patch on the next commitfest page.
--
Tatsuhito Kasahara
kasahara.tatsuhito@oss.ntt.co.jp
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: display previous query string of idle-in-transaction
@ 2009-06-05 02:22 Robert Haas <robertmhaas@gmail.com>
parent: Tatsuhito Kasahara <kasahara.tatsuhito@oss.ntt.co.jp>
0 siblings, 0 replies; 4+ messages in thread
From: Robert Haas @ 2009-06-05 02:22 UTC (permalink / raw)
To: Tatsuhito Kasahara <kasahara.tatsuhito@oss.ntt.co.jp>; +Cc: Kevin Grittner <Kevin.Grittner@wicourts.gov>; Greg Stark <stark@enterprisedb.com>; Asko Oja <ascoja@gmail.com>; Simon Riggs <simon@2ndquadrant.com>; decibel <decibel@decibel.org>; pgsql-hackers
On Thu, Jun 4, 2009 at 9:54 PM, Tatsuhito
Kasahara<kasahara.tatsuhito@oss.ntt.co.jp> wrote:
> Kevin Grittner wrote:
>>
>> Greg Stark <stark@enterprisedb.com> wrote:
>>>
>>> Should this patch be on the commitfest page for 8.5? Or is there a
>>> consensus already that it's a bad idea?
>>>
>>> Personally I actually think this makes a lot of sense to do.
>>
>> +1
>> It at least gives one a reasonable chance to get a useful clue....
>
> +1
> # And I'm going to register this patch on the next commitfest page.
I don't actually remember seeing actual code to implement this - is
this a patch, or just an idea? (I guess if this gets added to the
CommitFest page there will be a pointer to the code, but somehow I
can't find it at the moment.)
The only thing I don't like about this is that I think it's kind of a
hack to shove the <IDLE> in transaction designation and the query
string into the same database column. I've never liked having to
write:
select sum(1) from pg_stat_activity where current_query = '<IDLE> in
transaction';
...and I like it even less if I now have to modify that query to use
"like". We should find some way to represent this as structured
data... maybe make a separate column called "idle" that's a boolean,
or something, and let the query column contain the most recent query
(whether or not it's still executing).
...Robert
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2009-06-05 02:22 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-03 14:24 Re: display previous query string of idle-in-transaction Greg Stark <stark@enterprisedb.com>
2009-06-03 14:33 ` Kevin Grittner <Kevin.Grittner@wicourts.gov>
2009-06-05 01:54 ` Re: display previous query string of idle-in-transaction Tatsuhito Kasahara <kasahara.tatsuhito@oss.ntt.co.jp>
2009-06-05 02:22 ` Robert Haas <robertmhaas@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox