From: Teodor Sigaev <teodor@sigaev.ru>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: KNNGiST for knn-search (WIP)
Date: Wed, 30 Dec 2009 17:59:53 +0300
Message-ID: <4B3B6AE9.1000901@sigaev.ru> (raw)
In-Reply-To: <603c8f070912292255u30e1983bi22ed5778bd2ce890@mail.gmail.com>
References: <4B0AC9E1.5050509@sigaev.ru>
<4B0EAE0D.606@sigaev.ru>
<603c8f070912292255u30e1983bi22ed5778bd2ce890@mail.gmail.com>
> changes should be made. It does also need to be updated to CVS HEAD,
> as it no longer applies cleanly.
The reason was a point_ops patch, some OIDs become duplicated. Both attached
patches are synced with current CVS.
>
> I tend to feel that we should probably target this for 8.6 rather than
> 8.5. We are down to the last CommitFest, and while we don't have a
> nailed-down criterion for what is "too big" for the last CommitFest of
> a given release cycle, this is definitely a big, invasive patch. This
Is we really have rule to accept only small patches at last CommitFest? May be,
FixFest name is better for it? :)
Actually, it's easy to split patch to several ones:
- contrib/pg_trgm
- contrib/btree_gist
- knngist itself
- planner changes
And knngist depends on rbtree and point_ops patch, in summary 6 dependent
patches. Is it more comfortable?
--
Teodor Sigaev E-mail: teodor@sigaev.ru
WWW: http://www.sigaev.ru/Attachments:
builtin_knngist-0.5.1.gz (application/x-tar, 26.8K) download
builtin_knngist-0.5.gz (application/x-tar, 25.5K) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: teodor@sigaev.ru, robertmhaas@gmail.com
Subject: Re: KNNGiST for knn-search (WIP)
In-Reply-To: <4B3B6AE9.1000901@sigaev.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox