From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: Order of operations in lazy_vacuum_rel
Date: Mon, 08 Feb 2010 22:01:05 +0200
Message-ID: <4B706D81.7010600@enterprisedb.com> (raw)
In-Reply-To: <20100208191917.GO4113@alvh.no-ip.org>
References: <13481.1265650179@sss.pgh.pa.us>
<20100208173855.GN4113@alvh.no-ip.org>
<13824.1265651227@sss.pgh.pa.us>
<20100208191917.GO4113@alvh.no-ip.org>
Alvaro Herrera wrote:
> Tom Lane wrote:
>> The point would be to not disable interrupts till after doing the FSM
>> vacuuming. Ignoring CANCEL for longer than we must is bad.
>
> Oh, I see. I guess the answer is that it depends on what happens if you
> interrupt after vacuuming the FSM. I have no idea what that is supposed
> to accomplish so I'm of no help here. FreeSpaceMapVacuum says it's
> about fixing inconsistencies in the FSM, so I'm guessing that it's not
> critical.
Yeah, interrupting FreeSpaceMapVacuum (or right after it) is harmless.
> FWIW I notice that RelationTruncate contains an outdated comment at the
> top about the 'fsm' function argument which is nowadays no longer an
> argument.
Thanks, fixed.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: heikki.linnakangas@enterprisedb.com, alvherre@commandprompt.com, tgl@sss.pgh.pa.us
Subject: Re: Order of operations in lazy_vacuum_rel
In-Reply-To: <4B706D81.7010600@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox