From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Simon Riggs <sriggs@postgresql.org>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Tune GetSnapshotData() during Hot Standby by avoiding loop
Date: Mon, 19 Apr 2010 10:36:17 +0300
Message-ID: <4BCC07F1.6040405@enterprisedb.com> (raw)
In-Reply-To: <20100418180608.16F067541D1@cvs.postgresql.org>
References: <20100418180608.16F067541D1@cvs.postgresql.org>
Simon Riggs wrote:
> Log Message:
> -----------
> Tune GetSnapshotData() during Hot Standby by avoiding loop
> through normal backends. Makes code clearer also, since we
> avoid various Assert()s. Performance of snapshots taken
> during recovery no longer depends upon number of read-only
> backends.
I think there's a little race condition there.
snapshot->takenDuringRecovery is set before acquiring ProcArrayLock, so
it's possible that by the time we acquire the lock, we're no longer in
recovery. So this can happen:
1. Backend A starts to take a snapshot, while we're still in recovery.
takenDuringRecovery is assigned true.
2. Recovery ends, and a normal transaction X begins in backend B.
3. A skips scanning ProcArray because takenDuringRecovery is true.
The snapshot doesn't include X, so any changes done in that transaction
will not be visible to the snapshot while the transaction is still
running, but will be after it commits.
Of course, it's highly improbable for 2. to happen, but it's there.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: heikki.linnakangas@enterprisedb.com, sriggs@postgresql.org, pgsql-committers@postgresql.org
Subject: Re: pgsql: Tune GetSnapshotData() during Hot Standby by avoiding loop
In-Reply-To: <4BCC07F1.6040405@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox