From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Dan Ports <drkp@csail.mit.edu>
Cc: pgsql-hackers@postgresql.org, YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
Cc: Kevin Grittner <Kevin.Grittner@wicourts.gov>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Subject: Re: SSI bug?
Date: Mon, 11 Apr 2011 14:01:22 +0300
Message-ID: <4DA2DF82.1090407@enterprisedb.com> (raw)
In-Reply-To: <20110403061644.GS81592@csail.mit.edu>
References: <4D8F54E6020000250003BD16@gw.wicourts.gov>
<4D8F54E6020000250003BD16@gw.wicourts.gov>
<20110328031616.CDAA719CEDF@mail.netbsd.org>
<4D943BEC020000250003BFDA@gw.wicourts.gov>
<20110403061644.GS81592@csail.mit.edu>
On 03.04.2011 09:16, Dan Ports wrote:
> I think I see what is going on now. We are sometimes failing to set the
> commitSeqNo correctly on the lock. In particular, if a lock assigned to
> OldCommittedSxact is marked with InvalidSerCommitNo, it will never be
> cleared.
>
> The attached patch corrects this:
> TransferPredicateLocksToNewTarget should initialize a new lock
> entry's commitSeqNo to that of the old one being transferred, or take
> the minimum commitSeqNo if it is merging two lock entries.
>
> Also, CreatePredicateLock should initialize commitSeqNo for to
> InvalidSerCommitSeqNo instead of to 0. (I don't think using 0 would
> actually affect anything, but we should be consistent.)
>
> I also added a couple of assertions I used to track this down: a
> lock's commitSeqNo should never be zero, and it should be
> InvalidSerCommitSeqNo if and only if the lock is not held by
> OldCommittedSxact.
>
Thanks, committed this.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: heikki.linnakangas@enterprisedb.com, drkp@csail.mit.edu, yamt@mwd.biglobe.ne.jp, Kevin.Grittner@wicourts.gov
Subject: Re: SSI bug?
In-Reply-To: <4DA2DF82.1090407@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox