From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Shigeru Hanada <shigeru.hanada@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: WIP: Collecting statistics on CSV file data
Date: Mon, 21 Nov 2011 13:00:06 +0900
Message-ID: <4EC9CCC6.4030906@lab.ntt.co.jp> (raw)
In-Reply-To: <CA+TgmoYVsh3eawS_j7Oj+1vO_oM7qC3vNh9YsWZk2NS6G19BNQ@mail.gmail.com>
References: <4E6DE18B.4010505@lab.ntt.co.jp>
<4E7861C1.2000607@gmail.com>
<4E8EC1D8.3080700@lab.ntt.co.jp>
<4E9C6573.8050507@gmail.com>
<4E9FF04B.3050504@lab.ntt.co.jp>
<4EB7C07A.5030205@gmail.com>
<4EC60883.2050905@lab.ntt.co.jp>
<4EC648CA.5050904@gmail.com>
<CA+TgmoYVsh3eawS_j7Oj+1vO_oM7qC3vNh9YsWZk2NS6G19BNQ@mail.gmail.com>
(2011/11/19 0:54), Robert Haas wrote:
> 2011/11/18 Shigeru Hanada<shigeru.hanada@gmail.com>:
>> - I couldn't see the reason why file_fdw sets ctid of sample tuples,
>> though I guess it's for Vitter's random sampling algorithm. If every
>> FDW must set valid ctid to sample tuples, it should be mentioned in
>> document of AnalyzeForeignTable. Exporting some functions from
>> analyze.c relates this issue?
>
> If every FDW must set valid ctid to sample tuples, it should be fixed
> so that they don't have to, I would think.
It's for neither Vitter's algorithm nor exporting functions from
analyze.c. It's for "foreign index scan" on CSV file data that I plan
to propose in the next CF. So, it is meaningless for now. I'm sorry.
I will fix it at the next version of the patch so that they don't have to.
Best regards,
Etsuro Fujita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: fujita.etsuro@lab.ntt.co.jp, robertmhaas@gmail.com, shigeru.hanada@gmail.com
Subject: Re: WIP: Collecting statistics on CSV file data
In-Reply-To: <4EC9CCC6.4030906@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox