pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Euler Taveira de Oliveira <euler@timbira.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: xlog location arithmetic
Date: Sat, 25 Feb 2012 20:53:19 -0300
Message-ID: <4F49746F.2000706@timbira.com> (raw)
In-Reply-To: <CABUevEwb8hS1Z7mnZjqbo8WBCe-XiSJ9UYXcWWrDo30qbFCm-g@mail.gmail.com>
References: <4EDD97E5.8080201@timbira.com>
	<CABUevEzBfLk=8Q9NHAJyNMQPRRvSNAsE+dS2gBiFON8VG5cBCw@mail.gmail.com>
	<CA+TgmoZRMNN0eVEsD-kxB9e-MvdmwoTi6guuJUvQP_8q2C5Cyg@mail.gmail.com>
	<4EDE5853.3080808@timbira.com>
	<CA+TgmoYfaSW8PWUX45Jo1ZSPEbMDPaDdjcGnKr76CGJ1jyZm5w@mail.gmail.com>
	<CABUevEx4K5WkWwz4pHkPBpLHOND0aXxP-3oKUmTg9RYCzWzjHA@mail.gmail.com>
	<4EF088E2.3090607@timbira.com>
	<CABUevEyXUZ=-wONOw-vEaXsrhCS80v1Y4_hN7xWOPAJ8LfTFaA@mail.gmail.com>
	<18871.1324652754@sss.pgh.pa.us>
	<4F1AE435.50000@timbira.com>
	<CAHGQGwGDv-moTqTZtCRb=q0QA4Cx4Ewy_kdD0u4gL4Fg1HPFZQ@mail.gmail.com>
	<4F315F6C.8030700@timbira.com>
	<CAHGQGwEV==i8q50KpKBqpG+L6KMuE+XwUFc9FpuWb1+LMfUwDQ@mail.gmail.com>
	<4F3441FE.1020008@timbira.com>
	<CAHGQGwFW3drMELnwytG5P1Vqk2HBcQbH4M1_jeHLN6L5E2GyNg@mail.gmail.com>
	<CABUevEwb8hS1Z7mnZjqbo8WBCe-XiSJ9UYXcWWrDo30qbFCm-g@mail.gmail.com>

On 25-02-2012 09:23, Magnus Hagander wrote:
> Do we even *need* the validate_xlog_location() function? If we just
> remove those calls, won't we still catch all the incorrectly formatted
> ones in the errors of the sscanf() calls? Or am I too deep into
> weekend-mode and missing something obvious?
> 
sscanf() is too fragile for input sanity check. Try
pg_xlog_location_diff('12/3', '-10/0'), for example. I won't object removing
that function if you protect xlog location input from silly users.


-- 
   Euler Taveira de Oliveira - Timbira       http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento



view thread (61+ messages)  latest in thread

Message-ID: <4F49746F.2000706@timbira.com>
Permalink:  ../4F49746F.2000706@timbira.com/
Also on:    postgresql.org/message-id/4F49746F.2000706@timbira.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: euler@timbira.com, magnus@hagander.net, masao.fujii@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
  Subject: Re: xlog location arithmetic
  In-Reply-To: <4F49746F.2000706@timbira.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox