pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Boszormenyi Zoltan <zb@cybertec.at>
To: Noah Misch <noah@leadboat.com>
To: Robert Haas <robertmhaas@gmail.com>
To: Michael Meskes <meskes@postgresql.org>
To: PG Hackers <pgsql-hackers@postgresql.org>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Bruce Momjian <bruce@momjian.us>
Subject: Re: ECPG FETCH readahead
Date: Thu, 29 Mar 2012 21:20:04 +0200
Message-ID: <4F74B5E4.6010105@cybertec.at> (raw)
In-Reply-To: <20120329183448.GA14785@feivel.credativ.lan>
References: <20120302164105.GD23100@tornado.leadboat.com>
	<4F538B4C.1030605@cybertec.at>
	<20120305185632.GE13348@tornado.leadboat.com>
	<4F55A9AD.6050600@cybertec.at>
	<20120306110658.GC15988@tornado.leadboat.com>
	<CA+TgmoaBGLpW5V3nFES-McLbZyY_9nUvpnFLjT7zAYuVPu809A@mail.gmail.com>
	<4F6D9893.3030300@cybertec.at>
	<20120329004323.GA17329@tornado.leadboat.com>
	<4F74409C.3050904@cybertec.at>
	<20120329170341.GA4142@tornado.leadboat.com>
	<20120329183448.GA14785@feivel.credativ.lan>

2012-03-29 20:34 keltezéssel, Michael Meskes írta:
> On Thu, Mar 29, 2012 at 01:03:41PM -0400, Noah Misch wrote:
>> Still, we're looking at dedicated ECPG syntax, quite visible even to folks
>> with no interest in Informix.  We have eschewed littering our syntax with
>> compatibility aids, and I like it that way.  IMO, an option to the "ecpg"
>> preprocessor is an acceptable level of muddle to provide this aid.  A DECLARE
>> CURSOR syntax extension goes too far.
> +1 from me.
>
> Let's not add special ecpg sql syntax if we don't absolutely have to.
>
> Michael

This is what I waited for, finally another opinion. I will delete this
from the grammar.

What about the other question about the 0 vs 1 distinction?

Without the second patch, 0 drives the cursor with the old
ECPGdo() code. All other values drive the cursor via the new
ECPGopen() et.al. Should we keep this behaviour? In this case
the 0 vs 1 distinction is not needed in add_cursor() as the 0
value doesn't even reach ECPGopen().

But if we consider including the second patch as well, should we
keep the "NO READAHEAD" option in the grammar and in cursor.c?
After solving the problem with WHERE CURRENT OF, this and
the 0-vs-1 distinction starts to feel pointless.

And what about the override via the environment variable?
Should it work only upwards?

Best regards,
Zoltán Böszörményi

-- 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig&  Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
      http://www.postgresql.at/




view thread (69+ messages)  latest in thread

Message-ID: <4F74B5E4.6010105@cybertec.at>
Permalink:  ../4F74B5E4.6010105@cybertec.at/
Also on:    postgresql.org/message-id/4F74B5E4.6010105@cybertec.at

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: zb@cybertec.at, noah@leadboat.com, robertmhaas@gmail.com, meskes@postgresql.org, heikki.linnakangas@enterprisedb.com, bruce@momjian.us
  Subject: Re: ECPG FETCH readahead
  In-Reply-To: <4F74B5E4.6010105@cybertec.at>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox